Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SPI Error Messages #16619

Merged
merged 5 commits into from
Oct 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@
*/
public final class HttpClientProviders {
private static HttpClientProvider defaultProvider;
private static final String CANNOT_FIND_HTTP_CLIENT =
"Cannot find any HttpClient provider on the classpath - unable to create a default HttpClient instance";
private static final String CANNOT_FIND_HTTP_CLIENT = "A request was made to load the default HttpClient provider "
+ "but one could not be found on the classpath. If you are using a dependency manager, consider including a "
+ "dependency on azure-core-http-netty or azure-core-http-okhttp. Depending on your existing dependencies, you "
+ "have the choice of Netty or OkHttp implementations. Additionally, refer to "
+ "https://aka.ms/azsdk/java/docs/custom-httpclient to learn about writing your own implementation.";

static {
ServiceLoader<HttpClientProvider> serviceLoader = ServiceLoader.load(HttpClientProvider.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@
* This class is a proxy for using a {@link JsonSerializerProvider} loaded from the classpath.
*/
public final class JsonSerializerProviders {
private static final String CANNOT_FIND_JSON_SERIALIZER_PROVIDER =
"Cannot find any JSON serializer provider on the classpath.";
private static final String CANNOT_FIND_JSON_SERIALIZER_PROVIDER = "A request was made to load the default JSON "
+ "serializer provider but one could not be found on the classpath. If you are using a dependency manager, "
+ "consider including a dependency on azure-core-serializer-json-jackson or azure-core-serializer-json-gson. "
+ "Depending on your existing dependencies, you have the choice of Jackson or GSON implementations. "
+ "Additionally, refer to https://aka.ms/azsdk/java/docs/custom-jsonserializer to learn about writing your own "
+ "implementation.";

private static JsonSerializerProvider defaultProvider;
private static boolean attemptedLoad;
Expand Down