Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -beta tag from digital twins library #16395

Merged
merged 6 commits into from
Oct 15, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/versioning/version_client.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ com.azure:azure-data-appconfiguration;1.1.6;1.2.0-beta.1
com.azure:azure-data-schemaregistry;1.0.0-beta.4;1.0.0-beta.5
com.azure:azure-data-schemaregistry-avro;1.0.0-beta.4;1.0.0-beta.5
com.azure:azure-data-tables;12.0.0-beta.2;12.0.0-beta.3
com.azure:azure-digitaltwins-core;1.0.0-beta.3;1.0.0-beta.4
com.azure:azure-digitaltwins-core;1.0.0-beta.3;1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to do a GA release for Digitial twins?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon, yes. I'm bumping the version now so that the API reviews of this jar don't have this -beta tag in them

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of October. We'll be reviewing the GA impl with Azure SDK board again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the changes in this PR, but any reason why we don't have digital twins in the test coverage library pom here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can certainly add this library to that, sure!

com.azure:azure-e2e;1.0.0-beta.1;1.0.0-beta.1
com.azure:azure-identity;1.1.3;1.2.0-beta.3
com.azure:azure-identity-perf;1.0.0-beta.1;1.0.0-beta.1
Expand Down
11 changes: 10 additions & 1 deletion sdk/digitaltwins/azure-digitaltwins-core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
# Release History

## 1.0.0-beta.4 (Unreleased)
## 1.0.0 (Unreleased)

### New Features

- Regenerate protocol layer from service API version 2020-10-31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

- Update service API version to use service API version 2020-10-31 by default
- Add optional parameters for traceparent and tracestate to all service request APIs to support distributed tracing

### Breaking Changes

- Add messageId as mandatory parameter for telemetry APIs. Service API version 2020-10-31 requires this parameter.

## 1.0.0-beta.3 (2020-10-01)

Expand Down
2 changes: 1 addition & 1 deletion sdk/digitaltwins/azure-digitaltwins-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<groupId>com.azure</groupId>
<artifactId>azure-digitaltwins-core</artifactId>
<version>1.0.0-beta.4</version> <!-- {x-version-update;com.azure:azure-digitaltwins-core;current} -->
<version>1.0.0</version> <!-- {x-version-update;com.azure:azure-digitaltwins-core;current} -->

<name>Microsoft Azure client library for Digital Twins</name>
<description>This package contains the Microsoft Azure DigitalTwins client library.</description>
Expand Down