Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change groupId to com.azure and artifactId to azure-spring-cloud-starter-xxx #15792

Merged
merged 10 commits into from
Oct 9, 2020
Merged

Change groupId to com.azure and artifactId to azure-spring-cloud-starter-xxx #15792

merged 10 commits into from
Oct 9, 2020

Conversation

ZhuXiaoBing-cn
Copy link
Contributor

Change groupId to com.azure and artifactId to azure-spring-cloud-starter-xxx #13523

@ghost ghost added the azure-spring All azure-spring related issues label Sep 29, 2020
saragluna
saragluna requested changes Sep 30, 2020
View reviewed changes
eng/jacoco-test-coverage/pom.xml Outdated Show resolved Hide resolved
eng/jacoco-test-coverage/pom.xml Outdated Show resolved Hide resolved
eng/jacoco-test-coverage/pom.xml Outdated Show resolved Hide resolved
eng/jacoco-test-coverage/pom.xml Outdated Show resolved Hide resolved
eng/jacoco-test-coverage/pom.xml Outdated Show resolved Hide resolved
sdk/boms/azure-spring-boot-bom/pom.xml Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-sample-eventhubs-integration/pom.xml Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-sample-servicebus-integration/pom.xml Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-sample-storage-resource/pom.xml Outdated Show resolved Hide resolved
sdk/spring/pom.xml Outdated Show resolved Hide resolved
Update
74f8c43 
* the reference in the readme,
* Original artifact does not contain the starter, I removed them,
* File content update sort,
* Wrong artifact is modified,
* azure-spring-cloud-sample-xxxx-integration was modified to azure-spring-integration-sample-xxx.
@ZhuXiaoBing-cn
Copy link
Contributor Author

@saragluna thanks,I have modified it according to your suggestion

saragluna
saragluna requested changes Sep 30, 2020
View reviewed changes
...e-spring-boot-samples/azure-spring-cloud-sample-appconfiguration-conversion-complete/pom.xml Show resolved Hide resolved
...re-spring-boot-samples/azure-spring-cloud-sample-appconfiguration-conversion-initial/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-cloud-autoconfigure/README.md Show resolved Hide resolved
sdk/spring/azure-spring-cloud-context/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-eventhubs-stream-binder/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-eventhubs/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-integration-servicebus/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-storage-queue/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-storage-queue/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-starter-storage/README.md Outdated Show resolved Hide resolved
Xiaobing Zhu added 2 commits September 30, 2020 18:09
Update
1dd8e81 
* Remove version and tag in README
* No includes needed,  remove this plugin from this pom
* Add the updated version in CHANGLOG
Update
73dac9c 
* Add the updated version in CHANGLOG
@ZhuXiaoBing-cn
Copy link
Contributor Author

Update the above comments

saragluna
saragluna requested changes Oct 9, 2020
View reviewed changes
sdk/spring/azure-spring-cloud-context/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-eventhubs-stream-binder/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-servicebus-queue-stream-binder/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-servicebus-stream-binder-core/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-servicebus-topic-stream-binder/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-storage/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-eventhubs/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-servicebus/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-storage-queue/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-starter-storage/README.md Outdated Show resolved Hide resolved
Update
e47b8ae 
* dependency is modified [//]: # ({x-version-update-start;com.azure:azure-spring-cloud-context;current}),to keep the version
@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna
Copy link
Member

/check-enforcer override

@saragluna saragluna merged commit 2d84b96 into Azure:master Oct 9, 2020
@saragluna saragluna linked an issue Oct 9, 2020 that may be closed by this pull request
Spring Cloud artifactIds need to follow the naming guidance in the Java guidelines #13523
Closed
@ZhuXiaoBing-cn ZhuXiaoBing-cn deleted the update_groupId_and_artifactId branch October 13, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@jialindai jialindai Awaiting requested review from jialindai

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@srnagar srnagar Awaiting requested review from srnagar

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@samvaity samvaity Awaiting requested review from samvaity

@mssfang mssfang Awaiting requested review from mssfang

@mrm9084 mrm9084 Awaiting requested review from mrm9084

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Cloud artifactIds need to follow the naming guidance in the Java guidelines
2 participants
@ZhuXiaoBing-cn @saragluna