Change groupId to com.azure and artifactId to azure-spring-cloud-starter-xxx #15771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 24, 2020 15:17
…to work � Conflicts: � sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-cosmosdb/README.md � sdk/spring/azure-spring-boot-starter-cosmosdb/README.md � sdk/spring/azure-spring-cloud-servicebus-queue-stream-binder/README.md
ZhuXiaoBing-cn
requested review from
chenrujun,
jialindai,
JonathanGiles,
saragluna,
srnagar,
yiliuTo and
zhoufenqin
as code owners
ghost
added
the
moarychan
reviewed
Sep 28, 2020
| [docs]: https://docs.microsoft.com/azure/developer/java/spring-framework/configure-spring-boot-starter-java-app-with-cosmos-db | ||
| [refdocs]: https://azure.github.io/azure-sdk-for-java/spring.html#azure-cosmosdb-spring-boot-starter | ||
| [package]: https://mvnrepository.com/artifact/com.microsoft.azure/azure-cosmosdb-spring-boot-starter | ||
| [sample]: https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-spring-boot-samples/azure-spring-boot-sample-cosmosdb |
There was a problem hiding this comment.
should sync code from azure master first
moarychan
requested changes
Sep 28, 2020
There was a problem hiding this comment.
please comfirm with @wujack778 to avoid repeat modification.
Comment on lines
+213
to
+216
| <include>com.azure:azure-spring-cloud-starter-context:[1.3.0-beta.1]</include> <!-- {x-include-update;com.azure:azure-spring-cloud-starter-context;current} --> | ||
| <include>com.azure:azure-spring-cloud-starter-telemetry:[1.3.0-beta.1]</include> <!-- {x-include-update;com.azure:azure-spring-cloud-starter-telemetry;current} --> | ||
| <include>com.azure:azure-spring-integration-eventhubs:[1.3.0-beta.1]</include> <!-- {x-include-update;com.azure:azure-spring-integration-eventhubs;current} --> | ||
| <include>com.azure:azure-spring-integration-servicebus:[1.3.0-beta.1]</include> <!-- {x-include-update;com.azure:azure-spring-integration-servicebus;current} --> |
There was a problem hiding this comment.
we can remove all the dependencies which the group id starts with com.azure:xxx in bannedDependencies part.
|
this file https://github.com/ZhuXiaoBing-cn/azure-sdk-for-java/blob/work/sdk/spring/ci.yml should be updated together. |
* fix sample VerifyNetworkPeeringWithNetworkWatcher * enable VerifyNetworkPeeringWithNetworkWatcher
* mgmt update compute sample * update script link
…ice can perform an md5 verification. (#15625)
* Add tables module-info * Add java-lts profile for tables * Add unreleased dependency version for azure-storage-common
Fix missing JDK links in the track2 dataplane SDK READMEs
* Added OData filter expression helper class * Unit tests for SearchFilter * Fix linting issues
* Updating READMEs to have valid external links * Update links to remove locales * Fix README verify * Fix build errors * Fix build errors * Update package links * Update CHANGELOGs * Address PR comments * Address PR comments Co-authored-by: Minnie Liu <[email protected]>
ZhuXiaoBing-cn
requested review from
ChenTanyi,
conniey,
danieljurek,
drwill-ms,
g2vinay,
gapra-msft,
hemanttanwar,
jaschrep-msft,
jianghaolu,
JianpingChen,
JimSuplizio,
joshfree,
kasobol-msft,
mitchdenny,
mssfang,
RezaJooyandeh,
rickle-msft,
samvaity,
schaabs,
sjkwak,
timtay-microsoft,
vinagesh,
weidongxu-microsoft,
weshaggard,
xseeseesee,
YijunXieMS and
yungezz
as code owners
|
I am sorry that there are some problems in my repository and there are redundant submissions. I need to close this PR now. |
|
Hi, @ZhuXiaoBing-cn , you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update #13523