Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare azure-core-management for Release #15563

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Prepare azure-core-management for Release #15563

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5832a
Change azure-core and azure-core-http-netty versions to released vers…
alzimmermsft Sep 23, 2020
bf717e7
Merge branch 'master' into AzManagement_PrepCoreManagementForRelease
alzimmermsft Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/core/azure-core-management/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core</artifactId>
<version>1.9.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core;current} -->
<version>1.8.1</version> <!-- {x-version-update;com.azure:azure-core;dependency} -->
alzimmermsft marked this conversation as resolved.
Show resolved Hide resolved
</dependency>

<dependency>
Expand All @@ -83,7 +83,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-core-http-netty</artifactId>
<version>1.7.0-beta.1</version> <!-- {x-version-update;com.azure:azure-core-http-netty;current} -->
<version>1.6.1</version> <!-- {x-version-update;com.azure:azure-core-http-netty;dependency} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the last core release commit id to create a release branch to use the GA version? I guess @JimSuplizio recommends using current for modules belonging to the "same group".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there are a few wider changes made in azure-core-management and downstream libraries, it may be easier on the release process to change this to dependency just for release then going back to current. I agree that it isn't the most ideal situation.

<scope>test</scope>
</dependency>

Expand Down