RNTBDChannelPool design notes #15315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
requested review from
David-Noble-at-work,
FabianMeiswinkel and
moderakh
kirankumarkolli
requested review from
kushagraThapar,
mbhaskar,
milismsft,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
kirankumarkolli
commented
Sep 17, 2020
| @@ -131,7 +169,7 @@ | |||
| Comparator.comparingLong((task) -> task.originalPromise.getExpiryTimeInNanos())); | |||
|
|
|||
| private final ScheduledFuture<?> pendingAcquisitionExpirationFuture; | |||
|
|
|||
There was a problem hiding this comment.
Guess these are IntelliJ style default style changes.
Please help on how to use the common style.
kirankumarkolli
commented
Sep 17, 2020
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
Sep 17, 2020
Talked over the comments in-person. Latest version LGTM |
moderakh
approved these changes
Sep 21, 2020
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Outdated
Show resolved
Hide resolved
| * - max requests in-flight per channelPool: MAX_CHANNELS_PER_ENDPOINT * MAX_REQUESTS_ENDPOINT (NOT A GUARANTEE) | ||
| * - AvailableChannels.size() + AcquiredChannels.size() <= MAX_CHANNELS_PER_ENDPOINT | ||
| * - PendingAcquisition queue default-size: Max(10_000, MAX_CHANNELS_PER_ENDPOINT * MAX_REQUESTS_ENDPOINT) | ||
| * - ChannelPool executor event-loop task queue length: MAX_CHANNELS_PER_ENDPOINT * MAX_REQUESTS_ENDPOINT + newInFlightAcquisitions (not yet in pendingAcquisitionQueue) |
There was a problem hiding this comment.
how did we come up with the math?
I might be missing something not sure on the accuracy of this one, could you please validate?
There was a problem hiding this comment.
Closed it offline.
...in/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelPool.java
Show resolved
Hide resolved
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNTBDChannelPool design notes