Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed simple renames and doc issues from 74 #15297

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fixed simple renames and doc issues from 74 #15297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...e/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@

package com.azure.storage.blob.models;

import com.azure.core.annotation.Fluent;
import com.azure.storage.common.implementation.StorageImplUtils;

/**
* Defines an arrow field for a blob quick query request.
*/
@Fluent
public class BlobQueryArrowField {

private String name;
Expand Down Expand Up @@ -36,7 +38,7 @@ public BlobQueryArrowField setName(String name) {
* @param precision The precision of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL}
* @return The updated options.
*/
public BlobQueryArrowField setPrecision(int precision) {
public BlobQueryArrowField setPrecision(Integer precision) {
this.precision = precision;
return this;
}
Expand All @@ -45,7 +47,7 @@ public BlobQueryArrowField setPrecision(int precision) {
* @param scale The scale of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL}
* @return The updated options.
*/
public BlobQueryArrowField setScale(int scale) {
public BlobQueryArrowField setScale(Integer scale) {
this.scale = scale;
return this;
}
Expand Down
3 changes: 2 additions & 1 deletion ...-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ public String getVersion() {
*
* @param version Version to target
* @return the updated BlobServiceSASSignatureValues object
* @deprecated The version is set to the latest version of sas.
* @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now
* treated as a no-op.
*/
@Deprecated
public BlobServiceSasSignatureValues setVersion(String version) {
Expand Down
6 changes: 3 additions & 3 deletions ...-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ public Mono<Response<AccessControlChangeResult>> setAccessControlRecursiveWithRe
return withContext(context -> setAccessControlRecursiveWithResponse(
PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(),
options.isContinuingOnFailure(), options.getContinuationToken(), context));
options.isContinueOnFailure(), options.getContinuationToken(), context));
} catch (RuntimeException ex) {
return monoError(logger, ex);
}
Expand Down Expand Up @@ -746,7 +746,7 @@ public Mono<Response<AccessControlChangeResult>> updateAccessControlRecursiveWit
return withContext(context -> setAccessControlRecursiveWithResponse(
PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(),
options.isContinuingOnFailure(), options.getContinuationToken(), context));
options.isContinueOnFailure(), options.getContinuationToken(), context));
} catch (RuntimeException ex) {
return monoError(logger, ex);
}
Expand Down Expand Up @@ -796,7 +796,7 @@ public Mono<Response<AccessControlChangeResult>> removeAccessControlRecursiveWit
return withContext(context -> setAccessControlRecursiveWithResponse(
PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()),
options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(),
options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context));
options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context));
} catch (RuntimeException ex) {
return monoError(logger, ex);
}
Expand Down
6 changes: 3 additions & 3 deletions ...orage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ public Response<AccessControlChangeResult> setAccessControlRecursiveWithResponse
dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(),
options.isContinuingOnFailure(), options.getContinuationToken(), context);
options.isContinueOnFailure(), options.getContinuationToken(), context);

return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
}
Expand Down Expand Up @@ -443,7 +443,7 @@ public Response<AccessControlChangeResult> updateAccessControlRecursiveWithRespo
dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(),
options.isContinuingOnFailure(), options.getContinuationToken(), context);
options.isContinueOnFailure(), options.getContinuationToken(), context);

return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
}
Expand Down Expand Up @@ -488,7 +488,7 @@ public Response<AccessControlChangeResult> removeAccessControlRecursiveWithRespo
dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()),
options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(),
options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context);
options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context);

return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
}
Expand Down
6 changes: 4 additions & 2 deletions ...le-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@

package com.azure.storage.file.datalake.models;

import com.azure.core.annotation.Fluent;
import com.azure.storage.common.implementation.StorageImplUtils;

/**
* Defines an arrow field for a file quick query request.
*/
@Fluent
public class FileQueryArrowField {

private String name;
Expand Down Expand Up @@ -36,7 +38,7 @@ public FileQueryArrowField setName(String name) {
* @param precision The precision of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL}
* @return The updated options.
*/
public FileQueryArrowField setPrecision(int precision) {
public FileQueryArrowField setPrecision(Integer precision) {
this.precision = precision;
return this;
}
Expand All @@ -45,7 +47,7 @@ public FileQueryArrowField setPrecision(int precision) {
* @param scale The scale of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL}
* @return The updated options.
*/
public FileQueryArrowField setScale(int scale) {
public FileQueryArrowField setScale(Integer scale) {
this.scale = scale;
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public PathRemoveAccessControlRecursiveOptions setContinuationToken(String conti
*
* @return If the operation should continue on user failure.
*/
public boolean isContinuingOnFailure() {
public boolean isContinueOnFailure() {
return continueOnFailure;
}

Expand Down
2 changes: 1 addition & 1 deletion ...in/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public PathSetAccessControlRecursiveOptions setContinuationToken(String continua
*
* @return If the operation should continue on user failure.
*/
public boolean isContinuingOnFailure() {
public boolean isContinueOnFailure() {
return continueOnFailure;
}

Expand Down
2 changes: 1 addition & 1 deletion ...java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public PathUpdateAccessControlRecursiveOptions setContinuationToken(String conti
*
* @return If the operation should continue on user failure.
*/
public boolean isContinuingOnFailure() {
public boolean isContinueOnFailure() {
return continueOnFailure;
}

Expand Down
3 changes: 2 additions & 1 deletion .../src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ public String getVersion() {
*
* @param version Version to target
* @return the updated DataLakeServiceSasSignatureValues object
* @deprecated The version is set to the latest version of sas.
* @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now
* treated as a no-op.
*/
@Deprecated
public DataLakeServiceSasSignatureValues setVersion(String version) {
Expand Down