Add helpers for accessing sample resources #14706
Conversation
abhipsaMisra
force-pushed
the
feature/adt/abmisr/samples
branch
from
1c772f1 to
6121eaf
Compare
| @@ -78,6 +78,11 @@ | |||
| </dependencies> | |||
|
|
|||
| <build> | |||
| <resources> | |||
| <resource> | |||
| <directory>src/samples/resources</directory> | |||
There was a problem hiding this comment.
maven has inbuilt references to src/main/resources and src/test/resources. We need to add reference to src/samples/resources explicitly.
| public class DigitalTwinsLifecycleSample { | ||
| private static final ClientLogger logger = new ClientLogger(DigitalTwinsLifecycleSample.class); | ||
|
|
||
| private static final String tenantId = System.getenv("TENANT_ID"); |
There was a problem hiding this comment.
TODO: Add a command line options helper similar to .NET
There was a problem hiding this comment.
Can you add the "TODO:" as a comment so we can find it and resolve it later?
|
|
||
| private static final int MaxTimeForTwinOperationsInSeconds = 10; | ||
|
|
||
| private static final URL DtdlDirectoryUrl = DigitalTwinsLifecycleSample.class.getClassLoader().getResource("DTDL"); |
There was a problem hiding this comment.
This path to "resources" is returned as a URL
abhipsaMisra
requested review from
azabbasi,
barustum,
bikamani,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
| aVoid -> { }, | ||
| throwable -> { | ||
| // If digital twin does not exist, ignore. | ||
| if (!(throwable instanceof ErrorResponseException) || !((ErrorResponseException) throwable).getValue().getError().getCode().equals("DigitalTwinNotFound")) { |
There was a problem hiding this comment.
How to access response status code? ErrorResponse.getValue().getError().getCode() is string.
| public class DigitalTwinsLifecycleSample { | ||
| private static final ClientLogger logger = new ClientLogger(DigitalTwinsLifecycleSample.class); | ||
|
|
||
| private static final String tenantId = System.getenv("TENANT_ID"); |
| throw new RuntimeException(e); | ||
| } | ||
| TwinsPath = Paths.get(DtDlDirectoryPath.toString(), "DigitalTwins"); | ||
| ModelsPath = Paths.get(DtDlDirectoryPath.toString(), "Models"); |
There was a problem hiding this comment.
ModelPath and RelationshipsPath is not used here.
There was a problem hiding this comment.
It will be, in the rest of the sample (this sample creates models and relationships) :)
Add helper classes for accessing sample resources.