-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive acl #14669
Merged
gapra-msft
merged 19 commits into
Azure:feature/storage/stg74
from
rickle-msft:recursiveAcl
Sep 9, 2020
Merged
Recursive acl #14669
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
550f54c
Implemented setRecursiveAcl
rickle-msft 51dd280
Added remove/updateAcl and sync methods
rickle-msft bb2b8e9
Finished implementation. Need to start tests
rickle-msft 7893381
Finished writing tests
rickle-msft 3016175
Added recordings
rickle-msft a3c8def
Merge remote-tracking branch 'upstream/feature/storage/stg74' into re…
rickle-msft 024623b
Renamed options types
rickle-msft 4ead15e
Added javadoc codesnippets. Added file tests and recordings
rickle-msft eb44704
Added file missing from git
rickle-msft 6a904a5
ci analyze fixes
rickle-msft d023060
Updated tags for snippets
rickle-msft 10837f8
ditto
rickle-msft 13fbf34
Spotbugs
rickle-msft b9cf7cd
Spotbugs
rickle-msft dd5704a
PR feedback
rickle-msft 12a3dbd
Merge remote-tracking branch 'upstream/feature/storage/stg74' into re…
rickle-msft ed4fdb2
Fixed broken copy method
rickle-msft fdb1a85
Updated options to be strictly fluent
rickle-msft fc8ca00
Merge branch 'feature/storage/stg74' into recursiveAcl
gapra-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274 changes: 274 additions & 0 deletions
274
...-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...alake/src/main/java/com/azure/storage/file/datalake/implementation/models/AppendMode.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
// Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
||
package com.azure.storage.file.datalake.implementation.models; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonValue; | ||
|
||
/** | ||
* Defines values for AppendMode. | ||
*/ | ||
public enum AppendMode { | ||
/** | ||
* Enum value autoCreate. | ||
*/ | ||
AUTO_CREATE("autoCreate"); | ||
|
||
/** | ||
* The actual serialized value for a AppendMode instance. | ||
*/ | ||
private final String value; | ||
|
||
AppendMode(String value) { | ||
this.value = value; | ||
} | ||
|
||
/** | ||
* Parses a serialized value to a AppendMode instance. | ||
* | ||
* @param value the serialized value to parse. | ||
* @return the parsed AppendMode object, or null if unable to parse. | ||
*/ | ||
@JsonCreator | ||
public static AppendMode fromString(String value) { | ||
AppendMode[] items = AppendMode.values(); | ||
for (AppendMode item : items) { | ||
if (item.toString().equalsIgnoreCase(value)) { | ||
return item; | ||
} | ||
} | ||
return null; | ||
} | ||
|
||
@JsonValue | ||
@Override | ||
public String toString() { | ||
return this.value; | ||
} | ||
} |
50 changes: 50 additions & 0 deletions
50
...atalake/src/main/java/com/azure/storage/file/datalake/implementation/models/BlobType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
// Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
||
package com.azure.storage.file.datalake.implementation.models; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonValue; | ||
|
||
/** | ||
* Defines values for BlobType. | ||
*/ | ||
public enum BlobType { | ||
/** | ||
* Enum value appendblob. | ||
*/ | ||
APPENDBLOB("appendblob"); | ||
|
||
/** | ||
* The actual serialized value for a BlobType instance. | ||
*/ | ||
private final String value; | ||
|
||
BlobType(String value) { | ||
this.value = value; | ||
} | ||
|
||
/** | ||
* Parses a serialized value to a BlobType instance. | ||
* | ||
* @param value the serialized value to parse. | ||
* @return the parsed BlobType object, or null if unable to parse. | ||
*/ | ||
@JsonCreator | ||
public static BlobType fromString(String value) { | ||
BlobType[] items = BlobType.values(); | ||
for (BlobType item : items) { | ||
if (item.toString().equalsIgnoreCase(value)) { | ||
return item; | ||
} | ||
} | ||
return null; | ||
} | ||
|
||
@JsonValue | ||
@Override | ||
public String toString() { | ||
return this.value; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do the try catch error thing here so we can log it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea idk why we don't do it on all the datalake methods. I'll add it to all the other ones, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Looks like we don't do that for any of the methods in BlobClientBase either, so I think it'd be better to do that as a separate PR