Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate spring cloud starter repo #13935

Merged
merged 7 commits into from
Aug 11, 2020
Merged

migrate spring cloud starter repo #13935

merged 7 commits into from
Aug 11, 2020

Conversation

moarychan
Copy link
Member

JimSuplizio
JimSuplizio approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to pre-approve this as most of my requested changes just deal with the tags in the pom files being incorrect or inconsistent. I would expect another commit that updates/fixes those names before this is merged.

sdk/spring/azure-spring-cloud-starter-eventhubs-kafka/pom.xml Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-starter-eventhubs/pom.xml Show resolved Hide resolved
sdk/spring/azure-spring-cloud-starter-storage/pom.xml Outdated Show resolved Hide resolved
@saragluna
Copy link
Member

@JimSuplizio I will merge this PR now. We'll file another issue to change all our <name> tags to make sure they are correct and consistent.

saragluna
saragluna approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun merged commit c2c189c into Azure:master Aug 11, 2020
@moarychan moarychan deleted the feature/spring-cloud-starter-init branch September 16, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@JimSuplizio JimSuplizio JimSuplizio approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@danieljurek danieljurek Awaiting requested review from danieljurek

@jialindai jialindai Awaiting requested review from jialindai

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@srnagar srnagar Awaiting requested review from srnagar

@weshaggard weshaggard Awaiting requested review from weshaggard

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moarychan @saragluna @chenrujun @JimSuplizio