Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring integration azure init #13670

Merged

Conversation

moarychan
Copy link
Member

Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moarychan - The build failures you're seeing in core's From Source run are because of the dependencies and the fact that the -amd switch only does a single pass (it gets immediate dependents but their dependencies). Add the following under entries under the AdditionalModules section in sdk/core/ci.yml (note the group/artifact names make change based upon what I've asked @jialindai below).
- name: spring-integration-azure-core
groupId: com.microsoft.azure
- name: spring-integration-azure-test
groupId: com.microsoft.azure

sdk/spring/azure-spring-integration-storage-queue/pom.xml Outdated Show resolved Hide resolved
eng/versioning/version_client.txt Show resolved Hide resolved
@saragluna
Copy link
Member

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna added the azure-spring All azure-spring related issues label Aug 4, 2020
@saragluna
Copy link
Member

@JimSuplizio are we okay to merge now?

…pring-integration-azure-init

# Conflicts:
#	eng/versioning/external_dependencies.txt
@JimSuplizio
Copy link
Member

/azp run java - aggregate-reports

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this now. I did start an aggregate reports run just for completeness.

@saragluna saragluna merged commit b5c768c into Azure:master Aug 5, 2020
@moarychan moarychan deleted the feature/spring-integration-azure-init branch September 16, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants