-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated azure spring data cosmos group id and artifact id #12925
Merged
kushagraThapar
merged 6 commits into
Azure:master
from
kushagraThapar:update_spring_cosmos_group_id_artifact_id
Jul 9, 2020
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1f95e39
Updated azure spring data cosmos group id and artifact id
kushagraThapar 189829a
Sorted version client to alphabetical list
kushagraThapar 98e37a5
Merged latest master and resolved conflicts
kushagraThapar aade973
Fixed tests.yml with new safename for azure spring data cosmos
kushagraThapar 6f26e04
Increasing timeout for cosmos emulator builds since download step tak…
kushagraThapar d5552e8
Added comments for increasing the timeout value
kushagraThapar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,9 +251,9 @@ jobs: | |
TestName: Integration_Test_Spring_Data_Cosmosdb | ||
ServiceDirectory: cosmos | ||
Artifacts: | ||
- name: spring-data-cosmosdb | ||
groupId: com.microsoft.azure | ||
safeName: springdatacosmosdb | ||
- name: azure-spring-data-cosmos | ||
groupId: com.azure | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the artifact changing the safe name would be azurespringdatacosmos. The ci.yml apparently already has this change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yups, done. |
||
safeName: azurespringdatacosmos | ||
TimeoutInMinutes: 90 | ||
Matrix: | ||
Session_Integration: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a comment explaining that the timeout is extended because the Cosmos Emulator takes a very long time to download and link this bug: #12970
A glance through download times for Cosmos DB in Python and JS hosts shows that the download step is taking a very long time compared to Java. It's not clear why this is the case. The bug above is tracking this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the issue @danieljurek
I have added the comment in this PR .