Return null on GET 404 #1206
Merged
Return null on GET 404 #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,9 @@ protected BatchAccountImpl wrapModel(String name) { | |||
|
|
|||
| @Override | |||
| protected BatchAccountImpl wrapModel(BatchAccountInner inner) { | |||
| if (inner == null) { | |||
There was a problem hiding this comment.
might be simpler/cleaner to just say:
return (inner == null) ? inner : new .... ;
| @@ -66,6 +66,9 @@ protected BatchAccountImpl wrapModel(String name) { | |||
|
|
|||
| @Override | |||
| protected BatchAccountImpl wrapModel(BatchAccountInner inner) { | |||
| if (inner == null) { | |||
There was a problem hiding this comment.
might be simpler/cleaner to just say:
return (inner == null) ? null : new .... ;
There was a problem hiding this comment.
I actually find inline conditionals hard to read, particularly in this case the line gets too long with the inline constructor call. Inline conditionals are forbidden in Sun's original checkstyle rules: http://checkstyle.sourceforge.net/config_coding.html#AvoidInlineConditionals but we are not reinforcing it.
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
Return null on GET 404
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-for-java
that referenced
this pull request
Mar 21, 2019
…n the NextLink property could not be found (Azure#1206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior is throwing
CloudException. Changed to simply return null. Related PR: Azure/autorest-clientruntime-for-java#123