AnalyzerTextOptions ctors changes and name suffix on properties #11810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
alzimmermsft,
conniey,
mssfang and
samvaity
as code owners
|
/azp run java - search - tests |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
reviewed
Jun 5, 2020
| @@ -45,7 +45,7 @@ | |||
| * 'Simple', 'Stop', 'Whitespace' | |||
| */ | |||
| @JsonProperty(value = "analyzer") | |||
| private LexicalAnalyzerName analyzer; | |||
| private LexicalAnalyzerName analyzerName; | |||
There was a problem hiding this comment.
Two questions.
- Should this and
tokenizerNamebefinaland only set in the constructor? - If we choose not to do Blob storage hangs for files > about 3500 kb #1 should the other value be set to null when using
setAnalyzerNameorsetTokenizerName? Based on other code it appears these should be mutually exclusive.
There was a problem hiding this comment.
I have set the other one to null.
Also made tokenizerName and analyzerName final
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11794
#11801