Master merge

.gitignore

@@ -6,6 +6,8 @@ dist/
 
 #javadoc overview files generated from README.md
 readme_overview.html
+**/javadocTemp/**
+**/sourceTemp/**
 
 #External libs
 extlib/

eng/.docsettings.yml

@@ -144,8 +144,9 @@ known_content_issues:
   - ['sdk/storage/azure-storage-blob-nio/README.md', '#3113']
   - ['sdk/storage/azure-storage-internal-avro/README.md', '#3113']
   - ['sdk/storage/README.md', '#3113']
-  - ['sdk/textanalytics/azure-ai-textanalytics/swagger/README.md', '#3113']
+  - ['sdk/tables/azure-data-tables/swagger/README.md', '#3113']
   - ['sdk/template/azure-sdk-template/README.md','has other required sections']
+  - ['sdk/textanalytics/azure-ai-textanalytics/swagger/README.md', '#3113']
 
 package_indexing_exclusion_list:
   - azure-loganalytics-sample

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

@@ -239,6 +239,7 @@
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck"
             files="com.azure.storage.common.implementation.StorageImplUtils.java"/>
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.core.http.ProxyOptions.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.core.util.serializer.SerializerEncoding.java"/>
 
   <!-- Azure Core Test -->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files=".*[/\\]core[/\\]test[/\\].*\.java"/>
@@ -261,10 +262,6 @@
   <suppress checks="MethodName|MemberName|VisibilityModifier|TypeName"
             files="com.azure.identity.implementation.WindowsCredentialApi.java"/>
 
-  <!-- Use the logger in a Utility static method. -->
-  <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck"
-            files="com.azure.ai.textanalytics.Transforms.java"/>
-
   <!-- Use the logger in a Utility static method. -->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.ai.formrecognizer.Transforms.java" />
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.ai.formrecognizer.training.CustomModelTransforms.java" />
@@ -361,9 +358,25 @@
   <!-- Suppress checks for AutoRest generated Search code -->
   <!-- Hand-written classes should be specified here to be checked -->
   <suppress checks="."
-            files=".*[/\\]search[/\\]documents[/\\]implementation[/\\]((?!(GeoPointDeserializer|Iso8601DateDeserializer|SerializationUtil)).*)"/>
+            files=".*[/\\]search[/\\]documents[/\\]implementation[/\\]models[/\\]"/>
+  <suppress checks="."
+            files=".*[/\\]search[/\\]documents[/\\]indexes[/\\]implementation[/\\]models[/\\]"/>
   <suppress checks="."
-            files=".*[/\\]search[/\\]documents[/\\]models[/\\]((?!(CoordinateSystem|GeoPoint|IndexBatch|ValueFacetResult|RangeFacetResult)).*)"/>
+            files=".*[/\\]search[/\\]documents[/\\]implementation[/\\]converters[/\\]"/>
+  <suppress checks="."
+            files=".*[/\\]search[/\\]documents[/\\]implementation[/\\](DocumentsImpl|SearchIndexRestClientBuilder|SearchIndexRestClientImpl)"/>
+  <suppress checks="."
+            files=".*[/\\]search[/\\]documents[/\\]indexes[/\\]implementation[/\\](DataSourcesImpl|IndexersImpl|IndexesImpl|SkillsetsImpl|SynonymMapsImpl|SearchServiceRestClientBuilder|SearchServiceRestClientImpl)"/>
+  <suppress checks="."
+            files=".*[/\\]search[/\\]documents[/\\]models[/\\]((?!(CoordinateSystem|GeoPoint|IndexBatch|ValueFacetResult|RangeFacetResult|ComplexField|SearchableField|SimpleField|SearchFieldBase|IndexBatchException|ScoringParameter)).*)"/>
+  <suppress checks="GoodLoggingCheck" files="com.azure.search.documents.implementation.util.PrivateFieldAccessHelper.java"/>
+
+  <!-- Removed this rule after the issue gets fixed: https://github.com/Azure/azure-sdk-for-java/issues/11651-->
+  <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.search.documents.SearchAsyncClient.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.search.documents.SearchClient.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.search.documents.indexes.SearchIndexClient.java"/>
+  <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.search.documents.indexes.SearchIndexAsyncClient.java"/>
+<!--  <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files="com.azure.search.documents.SearchAsyncClient.java"/>-->
 
   <!-- Suppress external dependency check for jacksonwrapper overriding deserialize method -->
   <suppress checks="com.azure.tools.checkstyle.checks.ExternalDependencyExposedCheck"
@@ -395,7 +408,7 @@
 
   <!-- Don't enforce non-static ClientLogger instances in azure-core-mgmt PollerFactory and PollingState types-->
   <suppress checks="com\.azure\.tools\.checkstyle\.checks\.(ThrowFromClientLoggerCheck|GoodLoggingCheck)"
-            files="com.azure.core.management.implementation.polling.PollerFactory.java"/>
+            files="com.azure.core.management.implementation.polling.PollOperation.java"/>
   <suppress checks="com\.azure\.tools\.checkstyle\.checks\.(ThrowFromClientLoggerCheck|GoodLoggingCheck)"
             files="com.azure.core.management.implementation.polling.PollingState.java"/>
 

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -711,26 +711,6 @@
     <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/>
   </Match>
 
-
-  <!-- Azure search has generated code mixed with hand-written in these packages -->
-  <Match>
-    <And>
-      <Package name="~com\.azure\.search\.documents\.models"/>
-      <Not>
-        <Or>
-          <!-- Hand-written classes should be specified here to be checked  -->
-          <Class name="com.azure.search.documents.models.CoordinateSystem"/>
-          <Class name="com.azure.search.documents.models.GeoPoint"/>
-          <Class name="com.azure.search.documents.models.IndexBatch"/>
-          <Class name="com.azure.search.documents.models.ValueFacetResult"/>
-          <Class name="com.azure.search.documents.models.RangeFacetResult"/>
-          <Class name="com.azure.search.documents.models.IndexBatchException"/>
-          <Class name="com.azure.search.documents.models.ScoringParameter"/>
-        </Or>
-      </Not>
-    </And>
-  </Match>
-
   <!-- Initial implementation of JacksonDeserializer is using an inline class-->
   <Match>
     <Class name="com.azure.core.implementation.serializer.jsonwrapper.jacksonwrapper.JacksonDeserializer"/>
@@ -825,7 +805,7 @@
   <Match>
     <Or>
       <Class name="com.azure.cosmos.ClientSideRequestStatistics"/>
-      <Class name="com.azure.cosmos.models.CosmosAsyncItemResponse"/>
+      <Class name="com.azure.cosmos.models.CosmosItemResponse"/>
     </Or>
     <Bug pattern="IS2_INCONSISTENT_SYNC"/>
   </Match>
@@ -904,40 +884,6 @@
     <Bug pattern="DM_BOXED_PRIMITIVE_FOR_PARSING"/>
   </Match>
 
-  <!-- When setting the value which this method returns, it is ensured that value is of CosmosContainerProperties -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncContainerResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-  </Match>
-
-  <!-- When setting the value which this method returns, it is ensured that value is of CosmosDatabaseProperties -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncDatabaseResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-  </Match>
-
-  <!-- When setting the value which this method returns, it is ensured that value is of CosmosPermissionProperties -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncPermissionResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-  </Match>
-
-  <!-- When setting the value which this method returns, it is ensured that value is of CosmosStoredProcedureProperties -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncStoredProcedureResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-  </Match>
-
-  <!-- When setting the value which this method returns, it is ensured that value is of CosmosUserProperties -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncUserResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-  </Match>
 
   <!-- Extra null check is for assertion -->
   <Match>
@@ -957,7 +903,7 @@
    Issue: https://github.com/Azure/azure-sdk-for-java/issues/9054
    -->
   <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncItemResponse"/>
+    <Class name="com.azure.cosmos.models.CosmosItemResponse"/>
     <Method name="getItem"/>
     <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/>
   </Match>
@@ -1208,35 +1154,35 @@
 
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9054 -->
   <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncItemResponse"/>
+    <Class name="com.azure.cosmos.models.CosmosItemResponse"/>
     <Field name="item"/>
     <Bug pattern="DC_DOUBLECHECK"/>
   </Match>
 
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9088 -->
   <Match>
-    <Class name="com.azure.cosmos.CosmosClientException"/>
+    <Class name="com.azure.cosmos.CosmosException"/>
     <Field name="cosmosError"/>
     <Bug pattern="SE_BAD_FIELD"/>
   </Match>
 
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9088 -->
   <Match>
-    <Class name="com.azure.cosmos.CosmosClientException"/>
-    <Field name="cosmosResponseDiagnostics"/>
+    <Class name="com.azure.cosmos.CosmosException"/>
+    <Field name="cosmosDiagnostics"/>
     <Bug pattern="SE_BAD_FIELD"/>
   </Match>
 
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9088 -->
   <Match>
-    <Class name="com.azure.cosmos.CosmosClientException"/>
+    <Class name="com.azure.cosmos.CosmosException"/>
     <Field name="requestTimeline"/>
     <Bug pattern="SE_BAD_FIELD"/>
   </Match>
 
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9088 -->
   <Match>
-    <Class name="com.azure.cosmos.CosmosClientException"/>
+    <Class name="com.azure.cosmos.CosmosException"/>
     <Field name="requestUri"/>
     <Bug pattern="SE_BAD_FIELD"/>
   </Match>
@@ -1608,13 +1554,6 @@
     <Bug pattern="UUF_UNUSED_FIELD"/>
   </Match>
 
-  <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9096 -->
-  <Match>
-    <Class name="com.azure.cosmos.models.CosmosAsyncConflictResponse"/>
-    <Method name="getProperties"/>
-    <Bug pattern="IL_INFINITE_RECURSIVE_LOOP"/>
-  </Match>
-
   <!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9096 -->
   <Match>
     <Class name="com.azure.cosmos.models.SqlParameterList"/>
@@ -1897,6 +1836,14 @@
     <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/>
   </Match>
 
+  <!-- Serializing a null value should return null to allow client to handle null cases
+    consistently instead of injecting null payload behavior from the payload. -->
+  <Match>
+    <Class name="com.azure.data.schemaregistry.avro.SchemaRegistryAvroSerializer"/>
+    <Method name="serialize"/>
+    <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/>
+  </Match>
+
   <!-- Exclude spotbug from non-shipping modules -->
   <Match>
     <Or>
@@ -2028,6 +1975,10 @@
     <Package name="~com\.azure\.management\.(.+)\.models"/>
     <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE,SKIPPED_CLASS_TOO_BIG"/>
   </Match>
+  <Match>
+    <Package name="~com\.azure\.management\.(.+)\.fluent"/>
+    <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE,SKIPPED_CLASS_TOO_BIG"/>
+  </Match>
 
   <!-- Exclude REC_CATCH_EXCEPTION for management samples. All samples in management catch Exception instead of throw it. -->
   <Match>

eng/common/TestResources/remove-test-resources.yml

@@ -32,4 +32,5 @@ steps:
         -Force `
         -Verbose
     displayName: Remove test resources
+    condition: and(ne(variables['AZURE_RESOURCEGROUP_NAME'], ''), succeededOrFailed())
     continueOnError: true

eng/common/pipelines/templates/steps/docs-metadata-release.yml

@@ -56,6 +56,3 @@ steps:
     BaseBranchName: smoke-test
     WorkingDirectory: ${{parameters.WorkingDirectory}}/repo
     ScriptDirectory: ${{parameters.WorkingDirectory}}/${{parameters.ScriptDirectory}}
-
-
-