Updated KeyVault's client-runtime version that fixes issue #6553. #11045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
requested changes
May 12, 2020
There was a problem hiding this comment.
@vcolin7 the correct way to update the dependency is to
- update the entry in eng/versioning/external_dependencies.txt
- Running eng/versioning/update_versions.py from the root of the enlistment with the following command will update the external dependencies in the pom files.
python eng/versioning/update_versions.py --ut external_dependency --sr
Your change only updated sdk/keyvault/microsoft-azure-keyvault/pom.xml however sdk/keyvault/microsoft-azure-keyvault-extensions/pom.xml has the same dependency.
This is also the reason that the build analyze step failed. The pom file version scanner verifies that the versions in the pom files match what's in the various versioning files.
|
@JimSuplizio Thanks a lot! Will make the appropriate changes. |
vcolin7
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
JimSuplizio
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.