Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] Updated batch to support batch account creation with fluent pattern. #1066

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

anudeepsharma
Copy link
Contributor

Updated batch to support batch account creation with fluent pattern.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anudeepsharma anudeepsharma force-pushed the Batch branch 4 times, most recently from 8c6854e to 65b1f64 Compare September 12, 2016 22:01
@anudeepsharma anudeepsharma changed the title Updated batch to support batch account creation with fluent pattern. [Ready for review] Updated batch to support batch account creation with fluent pattern. Sep 13, 2016
@anudeepsharma anudeepsharma force-pushed the Batch branch 9 times, most recently from 7c51926 to 12ccba3 Compare September 14, 2016 20:32
@jianghaolu
Copy link
Contributor

@azuresdkci add to whitelist

@azuresdkci
Copy link
Contributor

Runtime changes detected. pull request created. CI running: Build Status

* @throws CloudException exception thrown from REST call
* @throws IOException exception thrown from serialization/deserialization
*/
BatchAccountKeys keys() throws CloudException, IOException;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this is a separate call to Azure. If that's the case, we're starting to follow the convention to use "get" as the prefix on such methods, to indicate the info is not a property but a separate method that calls Azure. So in this case, we could call this getKeys()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to set of 2 functions keys and refreshKeys which are similar to Storage key apis.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm guessing you mean .keys() would quickly return the locally cached keys and refreshKeys() would make th actual call (and return the keys as well, right?) that makes sense to me as well.
I assume this will be added to this PR (not seeing a new commit yet)

*
* @return the stage representing updatable batch account definition
*/
Update removeStorageAccount();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the convention we use for removing things is "without..." so it'd be withoutStorageAccount()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@martinsawicki martinsawicki merged commit 9af3fa5 into Azure:master Sep 15, 2016
@anudeepsharma anudeepsharma deleted the Batch branch September 23, 2016 20:01
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
[Ready for review] Updated batch to support batch account creation with fluent pattern.
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
[Ready for review] Updated batch to support batch account creation with fluent pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants