fix for issue 998 - uniquely get a generic resource using name, group, type and provider info #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of duplicate names in same resource group GenericResources#getByGroup() has been removed since it doesn't make sense on GenericResources Instead, a new overload for GenericResources#get() has been added, requiring the 4 params uniquely identifying a resource
martinsawicki
changed the title
|
Can one of the admins verify this patch? |
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
fix for issue 998 - uniquely get a generic resource using name, group, type and provider info
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Feb 27, 2017
fix for issue 998 - uniquely get a generic resource using name, group, type and provider info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #998
Ability to uniquely get a generic resource in case of duplicate names in same resource group
GenericResources#getByGroup()has been removed since it is not going to have a predictable behavior onGenericResources. NormallygetByGroup()impls can already assume the resource type, but for generic resources, that cannot be assumed.Instead, a new overload for
GenericResources#get()has been added, requiring the 4 params uniquely identifying a resource