Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a PagedFlux type to support pagination #3937

Closed
JonathanGiles opened this issue Jun 17, 2019 · 1 comment
Closed

Introduce a PagedFlux type to support pagination #3937

JonathanGiles opened this issue Jun 17, 2019 · 1 comment
Assignees
@srnagar
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.

Comments

@JonathanGiles
Copy link
Member

Refer to the exploratory changes in my repo.

We need to offer improved pagination APIs. At present our pagination is transparent - users simply receive a Flux, and we transparently unroll the paged responses and put them into a Flux stream.

Rather than this, we should consider introducing a PagedFlux type. By default (as shown in the repo link above), the user will still be able to work with the common case of Flux, but by calling byPage(), the user will be able to get a Flux<PagedResponse<T>> and iterate per page, rather than per item.
@JonathanGiles JonathanGiles added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Jun 17, 2019
srnagar added a commit that referenced this issue Jun 28, 2019
@srnagar
Issue #3937: Paged flux draft PR (#4045)
bd592d3 
* Initial prototype for paged flux

* Update unit tests and javadocs

* Remove unused imports

* Updated to use paged response instead of continuation token

* Update javadocs

* Supplier and function

* Update javadocs, add code snippets and more unit tests

* Undo package-info changes

* Undo package-info changes

* Update javadocs

* Add jsr dependency

* Remove extra blank line
@srnagar
Copy link
Member

srnagar commented Jun 28, 2019

Done - #4045

@srnagar srnagar closed this as completed Jun 28, 2019
sima-zhu pushed a commit that referenced this issue Jun 29, 2019
@srnagar @sima-zhu
Issue #3937: Paged flux draft PR (#4045)
3331258 
* Initial prototype for paged flux

* Update unit tests and javadocs

* Remove unused imports

* Updated to use paged response instead of continuation token

* Update javadocs

* Supplier and function

* Update javadocs, add code snippets and more unit tests

* Undo package-info changes

* Undo package-info changes

* Update javadocs

* Add jsr dependency

* Remove extra blank line
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this issue Jun 29, 2019
@srnagar @sima-zhu
Issue Azure#3937: Paged flux draft PR (Azure#4045)
7e328f1 
* Initial prototype for paged flux

* Update unit tests and javadocs

* Remove unused imports

* Updated to use paged response instead of continuation token

* Update javadocs

* Supplier and function

* Update javadocs, add code snippets and more unit tests

* Undo package-info changes

* Undo package-info changes

* Update javadocs

* Add jsr dependency

* Remove extra blank line
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@srnagar srnagar

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonathanGiles @srnagar