Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Proxy setting not work in Azure AD B2C web application #31593

Closed
chenrujun opened this issue Oct 20, 2022 · 0 comments · Fixed by #31597
Closed

[BUG] Proxy setting not work in Azure AD B2C web application #31593

chenrujun opened this issue Oct 20, 2022 · 0 comments · Fixed by #31597
Assignees
@chenrujun
Labels
azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Milestone
2022-11

Comments

@chenrujun
Copy link

Context

  1. [BUG] Make sure all RestTemplate are managed by AadRestTemplateCreator #31347
  2. In Azure AD B2C web application, RestTemplate send the 2 http requests, both of them not supporting proxy setting.

https://rujche220928.b2clogin.com/rujche220928.onmicrosoft.com/oauth2/v2.0/token?p=B2C_1_sign_in_sing_up
https://rujche220928.b2clogin.com/rujche220928.onmicrosoft.com/discovery/v2.0/keys?p=B2C_1_sign_in_sing_up

Goal

Make sure all http requests send out by RestTemplate in Azure AD B2C web application supporting configure Proxy.
@chenrujun chenrujun self-assigned this Oct 20, 2022
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2022
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 20, 2022
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Oct 20, 2022
@chenrujun chenrujun added this to the 2022-11 milestone Oct 20, 2022
@chenrujun chenrujun mentioned this issue Oct 20, 2022
Closed
3 tasks
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this issue Oct 20, 2022
@rujche
Fix Azure#31593: Proxy setting not work in Azure AD B2C web application.
a931868 
1. Fix proxy setting for RestOperation which send http request to "../discovery/v2.0/keys?..".
2. Fix proxy setting for RestOperation which send http request to "../oauth2/v2.0/token?..".
3. Add unit tests and refactor tests.
@chenrujun chenrujun mentioned this issue Oct 20, 2022
Merged
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this issue Oct 20, 2022
@rujche
Fix Azure#31593: Proxy setting not work in Azure AD B2C web application.
0b5965a 
1. Fix proxy setting for RestOperation which send http request to "../discovery/v2.0/keys?..".
2. Fix proxy setting for RestOperation which send http request to "../oauth2/v2.0/token?..".
3. Add unit tests and refactor tests.
@chenrujun chenrujun moved this from Todo to In Progress in Spring Cloud Azure Oct 21, 2022
chenrujun pushed a commit that referenced this issue Oct 21, 2022
@rujche
Fix #31593: Proxy setting not work in Azure AD B2C web application (#…
46ebfb5 
…31597)

* Fix #31593: Proxy setting not work in Azure AD B2C web application.

1. Fix proxy setting for RestOperation which send http request to "https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/oauth2/v2.0/token?p={flow-name}".
2. Fix proxy setting for RestOperation which send http request to "https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/discovery/v2.0/keys?p={flow-name}".
3. Add unit tests and refactor tests.
4. Add a new item in CHANGELOG.md.
5. Fix pipeline caused by "cspell".
Repository owner moved this from In Progress to Done in Spring Cloud Azure Oct 21, 2022
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this issue Oct 21, 2022
@rujche
Fix Azure#31593: Proxy setting not work in Azure AD B2C web application
0cea6c9
@chenrujun chenrujun mentioned this issue Oct 21, 2022
Merged
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this issue Oct 24, 2022
@rujche
Fix Azure#31593: Proxy setting not work in Azure AD B2C web application
6644515
@chenrujun chenrujun mentioned this issue Oct 24, 2022
Merged
moarychan pushed a commit that referenced this issue Oct 25, 2022
@rujche
Feature/spring boot 3 fix bugs caused by supporting azure ad proxy (#…
5c2c4af 
…31684)

* Fix #31190. Put a value into Collections.emptyMap()
* Fix #31191. duplicated "scope" parameter.
* Fix 31218 rest template is not well configured when jwk resolver is null
* Fix #31482 rest template used to get access token should only contain 2 converters.
* Fix #31233: NimbusJwtDecoder still uses RestTemplate() instead RestTemplateBuilder
* Fix #31593: Proxy setting not work in Azure AD B2C web application
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
2022-11
Development

Successfully merging a pull request may close this issue.

Fix #31593: Proxy setting not work in Azure AD B2C web application chenrujun/azure-sdk-for-java
1 participant
@chenrujun