Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] spring-boot-starter-active-directory cannot start server #18085

Closed
3 tasks done
cccs-cat001 opened this issue Dec 11, 2020 · 2 comments
Closed
3 tasks done

[BUG] spring-boot-starter-active-directory cannot start server #18085

cccs-cat001 opened this issue Dec 11, 2020 · 2 comments
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@cccs-cat001
Copy link

Describe the bug
The server fails saying "Provider ID must be specified for client registration 'azure'" when trying to boot up. In going back through the code after building the azure-sdk again, I notice that teh AADAppRoleStatelessAuthenticationFilter is now deprecated.. Why? It's still a thing in the README file...

Exception or Stack Trace

714 [restartedMain] ERROR [o.s.boot.SpringApplication] - Application run failed 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'h2ConsoleSecurityConfig': Unsatisfied dependency expressed through method 'setContentNegotationStrategy' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration': Unsatisfied dependency expressed through method 'setConfigurers' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration': Unsatisfied dependency expressed through method 'setClientRegistrationRepository' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:723)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:116)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1422)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:594)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:879)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:878)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:550)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141)
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:747)
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:315)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215)
	at cccs.spellbook.server.SpellbookServerApplication.main(SpellbookServerApplication.java:13)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49)
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration': Unsatisfied dependency expressed through method 'setConfigurers' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration': Unsatisfied dependency expressed through method 'setClientRegistrationRepository' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:723)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:116)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1422)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:594)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:409)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1338)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1177)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:557)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:276)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1287)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1207)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:715)
	... 24 common frames omitted
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration': Unsatisfied dependency expressed through method 'setClientRegistrationRepository' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:723)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:116)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1422)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:594)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:276)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.addCandidateEntry(DefaultListableBeanFactory.java:1503)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.findAutowireCandidates(DefaultListableBeanFactory.java:1467)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveMultipleBeans(DefaultListableBeanFactory.java:1358)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1245)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1207)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:715)
	... 46 common frames omitted
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:656)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:636)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1338)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1177)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:557)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:517)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:323)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:321)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:276)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.addCandidateEntry(DefaultListableBeanFactory.java:1503)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.findAutowireCandidates(DefaultListableBeanFactory.java:1467)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveMultipleBeans(DefaultListableBeanFactory.java:1358)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1245)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1207)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:715)
	... 62 common frames omitted
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.InMemoryClientRegistrationRepository]: Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:185)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:651)
	... 78 common frames omitted
Caused by: java.lang.IllegalStateException: Provider ID must be specified for client registration 'azure'
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesRegistrationAdapter.getBuilder(OAuth2ClientPropertiesRegistrationAdapter.java:95)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesRegistrationAdapter.getClientRegistration(OAuth2ClientPropertiesRegistrationAdapter.java:61)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesRegistrationAdapter.lambda$getClientRegistrations$0(OAuth2ClientPropertiesRegistrationAdapter.java:53)
	at java.base/java.util.HashMap.forEach(HashMap.java:1336)
	at org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientPropertiesRegistrationAdapter.getClientRegistrations(OAuth2ClientPropertiesRegistrationAdapter.java:52)
	at org.springframework.boot.autoconfigure.security.oauth2.client.servlet.OAuth2ClientRegistrationRepositoryConfiguration.clientRegistrationRepository(OAuth2ClientRegistrationRepositoryConfiguration.java:49)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
	... 79 common frames omitted

To Reproduce
I built the whole repo as of commit 0e377a8cd81211085ec82ae7bd85ff8b7986d494, using the directions described here: https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/spring/CONTRIBUTING.md#building-from-source.
I added

<dependency>
     <groupId>com.azure.spring</groupId>
     <artifactId>azure-spring-boot-starter-active-directory</artifactId>
     <version>3.0.0-beta.2</version>
</dependency>

to my projects POM.
I have a websecurity thing:

@EnableGlobalMethodSecurity(prePostEnabled = true)
@Order(1)
@Configuration
public class WebSecurityConfig extends WebSecurityConfigurerAdapter {

  @Autowired
  private AADAppRoleStatelessAuthenticationFilter aadAuthFilter;

  @Override
  public void configure(WebSecurity web) throws Exception {
    web.ignoring().antMatchers("/**");
  }

  @Bean
  public AuthenticationEntryPoint entrypoint() {
    return new AuthenticationEntryPoint();
  }

  @Bean
  @Override
  public AuthenticationManager authenticationManager() throws Exception {
    return super.authenticationManagerBean();
  }

  @Override
  protected void configure(HttpSecurity http) throws Exception {
    http.sessionManagement().sessionCreationPolicy(SessionCreationPolicy.NEVER);
    http.anonymous().disable();
    // @formatter:off
    http.authorizeRequests()
      .antMatchers("OPTIONS").permitAll()
      .antMatchers("/login", "/login/**").permitAll()
      .anyRequest().authenticated().and()
    .exceptionHandling().authenticationEntryPoint(entrypoint());
    // @formatter:on
    http.csrf().disable();
    http.addFilterBefore(aadAuthFilter, UsernamePasswordAuthenticationFilter.class);
  }
}

Config:

azure.activedirectory.session-stateless=true
azure.activedirectory.tenant-id=
spring.security.oauth2.client.registration.azure.client-id=
azure.activedirectory.client-id=
azure.activedirectory.appIdUri=
spring.security.oauth2.client.registration.azure.client-secret=
azure.activedirectory.client-secret=

Code Snippet
Honestly not sure, perhaps that the AADAppRoleStatelessAuthenticationFilter is now deprecated?

Expected behavior
It used to work in a previous build of the beta.2...

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (please complete the following information):

  • OS: [e.g. iOS] any
  • IDE : [e.g. IntelliJ] any
  • Version of the Library used 3.0.0-beta.2

Additional context
Add any other context about the problem here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 11, 2020
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. labels Dec 11, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 11, 2020
@chenrujun chenrujun self-assigned this Dec 14, 2020
@chenrujun
Copy link

Hi, @cccs-cat001

The master branch is under developing, maybe documents in master branch is not updated yet, using released version(2.3.5) is suggested way.

For your problems in master branch:

The server fails saying "Provider ID must be specified for client registration 'azure'" when trying to boot up

I can not reproduce your problem with latest master branch. Here is my code: https://github.com/chenrujun/azure-sdk-for-java_issues_18085/tree/v0.0.1
I deleted some content like:

  @Bean
  public AuthenticationEntryPoint entrypoint() {
    return new AuthenticationEntryPoint();
  }

I notice that teh AADAppRoleStatelessAuthenticationFilter is now deprecated.. Why? It's still a thing in the README file...

Please read the java doc for more information.

 * For AADAppRoleStatelessAuthenticationFilter, suggest use spring-security resource-server directly and
 * include azure-spring-boot-starter-active-directory dependencies into your project. Automatic configuration of the
 * associated AAD will be started, they will work well together.
 * See the <a href="https://github.com/Azure/azure-sdk-for-java/issues/17860">Alternative method</a>.

Related readme: https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-spring-boot-starter-active-directory#examples

@saragluna
Copy link
Member

saragluna commented Jan 4, 2021

Hi @cccs-cat001, the latest version of aad starter's been released, check it out here https://mvnrepository.com/artifact/com.azure.spring/azure-spring-boot-starter-active-directory/3.0.0. And we've updated the README file https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-spring-boot-starter-active-directory too.

Yes, we deprecated the two filters in the latest release, but we've also integrated two common scenarios in our new AAD starter for applications used as RESTful servers.

  • If only used as a resource server, please check this.
  • If you also want the ability to access other AAD protected resource servers in your application, please check here.

Closing this issue now.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Mar 7, 2022
Dev sentinel 2022 01 01 preview (Azure#18025)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849)

* SourceControl 2022-01-01-preview version change

* fix validation error

* prettified

* prettified

Co-authored-by: debjyoti11 <[email protected]>

* New metadata API (Azure#17942)

* metadata changes

* addressed changes

* updated enum kind

* updated values as well

Co-authored-by: Roey Ben Chaim <[email protected]>

* added new enum to kind (Azure#17994)

Co-authored-by: Roey Ben Chaim <[email protected]>

* Add flag to rotate webhook secret (Azure#17989)

Co-authored-by: debjyoti11 <[email protected]>

* Align definitions with stable version (Azure#17931)

* Align definitions with stable version

* align scheduled rule and template properties with stable

* Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

Co-authored-by: Hassan Chawiche <[email protected]>

* Rename system to AutoAssigned (Azure#18061)

* Rename system to AutoAssigned

* Add example to list operations

* Update API version in NRT examples

* Execute validation tools and fix results (Azure#17733)

* Execute validation tools and fic results

* Prettyfieir GetIoTById.json

* Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

* fixing type version

* Update Watchlists.json

* Update DeleteWatchlist.json

* fixing commas

Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>

* Done (Azure#17843)

Co-authored-by: Roy Reinhorn <[email protected]>

* AutomationRules 2022-01-01-preview: Add constraints (Azure#18099)

* add contraints (alinged with the latest stable version)

Co-authored-by: debroy <[email protected]>
Co-authored-by: debjyoti11 <[email protected]>
Co-authored-by: RoeyBC <[email protected]>
Co-authored-by: Roey Ben Chaim <[email protected]>
Co-authored-by: Laith Hisham <[email protected]>
Co-authored-by: ushasan <[email protected]>
Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: shschwar <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: dosegal <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

5 participants