Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUERY] CosmosTemplate ignores CosmosPageRequest's offset #17924

Closed
siarheiburliayeu opened this issue Dec 2, 2020 · 4 comments
Closed

[QUERY] CosmosTemplate ignores CosmosPageRequest's offset #17924

siarheiburliayeu opened this issue Dec 2, 2020 · 4 comments
Assignees
@mbhaskar
Labels
azure-spring-cosmos Spring cosmos related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@siarheiburliayeu
Copy link

siarheiburliayeu commented Dec 2, 2020 •
edited
Loading

Question
Why does com.azure.spring.data.cosmos.core.CosmosTemplate::paginationQuery ignore com.azure.spring.data.cosmos.core.query.CosmosPageRequest's offset argument?

Why is this not a Bug or a feature Request?
Maybe it is.

Setup:

  • com.azure:azure-spring-data-cosmos:3.1.0
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 2, 2020
@ghost
Copy link

ghost commented Dec 2, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar, @anfeldma-ms

@kushagraThapar
Copy link
Member

@mbhaskar - please take a look at this issue.

@kushagraThapar kushagraThapar added the azure-spring-cosmos Spring cosmos related issues. label Dec 2, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2020
@jialindai jialindai added the Client This issue points to a problem in the data-plane of the library. label Feb 20, 2021
@kushagraThapar
Copy link
Member

@sburlyaev - this issue seems to be a duplicate of this #17927

@kushagraThapar
Copy link
Member

Closing it here.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Feb 28, 2022
@laithhisham @royrein @akning-ms
CodeGen from PR 17924 in Azure/azure-rest-api-specs
5d49e3d 
Dev securityinsights microsoft.security insights 2021 10 01 (Azure#17924)

* Adds base for updating Microsoft.SecurityInsights from version stable/2021-04-01 to version 2021-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AlertRules to microsoft.security insights 2021 10 01 (Azure#15657)

* Adds base for updating Microsoft.SecurityInsight's AlertRules from version stable/2020-01-01 to version 2021-10-01

* Updates API version in AlertRules specs and examples

* Use common types in AlertRules.json and remove redundant SecurityInsights

* Add AlertRules to readme

* Copy action examples for alert rules

* Add type:object where missing

* Align CloudError with rest of the resources in this version

* Update readme

Co-authored-by: Anat Gilenson <[email protected]>

* Use newest common types to align with rest of Azure (Azure#16130)

* Use newest common types to align with rest of Azure

* Use ErrorResponse instead of CloudError in operations

Co-authored-by: Anat Gilenson <[email protected]>

* Add AlertRules Stable version to 2021-10-01 (Azure#16268)

* Add AlertRules Stable version to 2021-10-01

* Fix missing alignment in common types

* prettier fixes

* move tactics and severity to common

* fix common types file extension

* more prettier fixes

* Add template version field

* prettier

* added version to required fields

* dummy change to trigger checks again

* Add onboarding states to new stable version (Azure#16290)

* Add onboarding states to new stable version

* Update readme.md

* cr fix - remove unused params

* Add missing resources 2021 10 01 (Azure#16666)

* Add missing resources and examples from 2020-01-01

* Update version in added resources and examples

* Use existing common types

* Remove unnesessary SecurityInsights.json

* Update readme

* Use sentinel common types in Incidents and Watchlist

* Extract and common IncidentInfo and IncidentSeverity

* Extract EntityTypes

* Correct double allOf in EntityTypes

* update readme

* Remove eventGroupingSettings and entityMappings from GetAlertRuleTemplateById example.

* rename operations.json

Co-authored-by: Anat Gilenson <[email protected]>

* Fix analytics templates model (Azure#16689)

* add missing properties to scheduled template

* prettier fixes

* restore templates example after merge

* fix templates example after merge and run prettier

* Use CloudError instead of ErrorResponse to align with preview versions and our back-end. (Azure#17472)

* Automation - Stable Version (Azure#17491)

* First

* readMe

* cloudError

* CloudError

* schema

* prettier

* Fix

* test

* fix identifier

* fix description

* fix lable

* fix lable

* ownerInfo

* Fix

* types

* conditionMaxLength

Co-authored-by: Roy Reinhorn <[email protected]>

* Done (Azure#17728)

Co-authored-by: Roy Reinhorn <[email protected]>

* Correct 2021 10 01 (Azure#17830)

* Remove OperationalInsightsResourceProvider parameter in ThreatIntelligence

* Remove OperationalInsightProviderParameter from Watchlist

* Align stable operation names with preview

* Add missing disciminator property in ThreatIntelligence

* Done (Azure#17844)

Co-authored-by: Roy Reinhorn <[email protected]>

* Align enum names with preview (Azure#17831)

* Fix 2021 10 01 validation errors (Azure#17937)

* Add x-ms-identifiers to all arrays

* Add operations_list example

* Add x-ms-identifier in all arrays

* Run prettier

* Fix spelling error

* Add isDataAction to operation schema (Azure#18018)

Co-authored-by: Anat Gilenson <[email protected]>
Co-authored-by: laithhisham <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mbhaskar mbhaskar

Labels
azure-spring-cosmos Spring cosmos related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbhaskar @siarheiburliayeu @kushagraThapar @jialindai