Merge branch 'master' of https://github.com/azure/azure-sdk-for-java …

…into 2874_fix

.azure-pipelines/.prettierrc.yml

@@ -0,0 +1 @@
+singleQuote: true

.azure-pipelines/client.test.live.yml

@@ -1,24 +1,41 @@
-variables:
-  - group: KeyVault Test Secrets
-  - name: ARM_CLIENTID
-    value: $(java-keyvault-test-arm-client-id)
-  - name: ARM_CLIENTKEY
-    value: $(java-keyvault-test-arm-client-key)
+jobs:
+  - job: 'LiveTest'
 
-queue:
-  name: Hosted VS2017
-steps:
-- bash: |
-   LOG_PARAMS='-Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
-   mvn test -Dhttp.keepAlive=false -Dsurefire.rerunFailingTestsCount=3 $LOG_PARAMS -f pom.client.build.xml 
-  displayName: 'Run Live Tests'
-  env:
-    ARM_CLIENTID: $(ARM_CLIENTID)
-    ARM_CLIENTKEY: $(ARM_CLIENTKEY)
-    AZURE_TEST_MODE: RECORD
-
-- task: PublishTestResults@2
-  inputs:
-    testResultsFormat: 'JUnit'
-    testResultsFiles: '**/TEST-*.xml' 
+    strategy:
+      matrix:
+        AzureBatch:
+          pomFilePath: './batch/data-plane/pom.xml'
+        AzureKeyVault:
+          pomFilePath: './keyvault/data-plane/pom.xml'
 
+    pool:
+      vmImage: 'vs2017-win2016'
+
+    steps:
+      # Adding -Dmaven.wagon.http.pool=false to the mvn command as a workaround to prevent build failures at maven artifacts downloading stage.
+      - task: Maven@3
+        displayName: 'Run Live tests'
+        inputs:
+          mavenPomFile: $(pomFilePath)
+          options: '--batch-mode -Dmaven.wagon.http.pool=false -Dsurefire.rerunFailingTestsCount=3'
+          mavenOptions: '-Xmx3072m -Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: '1.8'
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'test'
+        env:
+          ARM_CLIENTID: $(java-keyvault-test-arm-client-id)
+          ARM_CLIENTKEY: $(java-keyvault-test-arm-client-key)
+          AZURE_TEST_MODE: RECORD
+          AZURE_BATCH_ACCOUNT: $(java-batch-test-account-name)
+          AZURE_BATCH_ACCESS_KEY: $(java-batch-test-account-access-key)
+          STORAGE_ACCOUNT_KEY: $(java-batch-test-storage-account-key)
+          STORAGE_ACCOUNT_NAME: $(java-batch-test-storage-account-name)
+          AZURE_BATCH_ENDPOINT: https://servbatch.centralus.batch.azure.com
+
+      - task: PublishTestResults@2
+        condition: succeededOrFailed()
+        inputs:
+          mergeTestResults: true
+          testRunTitle: 'Live tests for $(pomFilePath)'

.azure-pipelines/client.yml

@@ -1,46 +1,177 @@
+# External variables Settable at queue time:
+# "pomFile" : "pom.client.xml".   This is the project object model file for Maven.
+
 trigger:
-- master
+  - master
+
+variables:
+  DefaultOptions: '--batch-mode -Dmaven.wagon.http.pool=false'
+  LoggingOptions: '-Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
 
 jobs:
-- job: 'Build'
-
-  pool:
-    vmImage: 'ubuntu-16.04'
-
-  steps:
-  - task: Maven@3
-    displayName: 'Build and Package'
-    inputs:
-      mavenPomFile: $(pomFile)
-      goals: 'checkstyle:check javadoc:jar source:jar package'
-      options: '--batch-mode -Dmaven.test.skip=true'
-      mavenOptions: '-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
-      javaHomeOption: 'JDKVersion'
-      jdkVersionOption: '1.8'
-      jdkArchitectureOption: 'x64'
-      publishJUnitResults: false
-
-  - powershell: |
-     # use sources files as a marker to find POM files so we can copy them to the output. The sources.jar file is generally
-     # in a target folder next to the pom.xml file so $_.Directory.Parent should get us the folder that contains the POM.
-     dir -r -i *-sources.jar | % { copy (Join-Path $_.Directory.Parent.FullName "pom.xml") (Join-Path $(Build.ArtifactStagingDirectory) $_.Name.Replace("-sources.jar",".pom")) }
-     dir -r -i *.jar | % { copy $_ $(Build.ArtifactStagingDirectory) }
-    displayName: 'Copy JAR and POM files to artifact staging'
-
-  - task: PublishBuildArtifacts@1
-    displayName: 'Publish'
-
-- template: client.test.yml
-  parameters:
-    name: Linux
-    vmImage: 'ubuntu-16.04'
-
-- template: client.test.yml
-  parameters:
-    name: macOS
-    vmImage: 'macOS-10.13'
-
-- template: client.test.yml
-  parameters:
-    name: Windows
-    vmImage: 'vs2017-win2016'
+  - job: 'Build'
+
+    pool:
+      vmImage: 'ubuntu-16.04'
+
+    strategy:
+      matrix:
+        Java 8:
+          ArtifactName: 'packages'
+          ProfileFlag: ''
+          JavaVersion: '1.8'
+        Java LTS:
+          ArtifactName: 'java-lts-packages'
+          ProfileFlag: '-Djava-lts'
+          JavaVersion: '1.11'
+
+    steps:
+      - task: Maven@3
+        displayName: 'Build and Package'
+        inputs:
+          mavenPomFile: $(pomFile)
+          goals: 'javadoc:jar source:jar package'
+          options: '$(DefaultOptions) $(ProfileFlag) -Dmaven.test.skip=true -Dinclude-template' # We include template-module so we ensure it always builds in CI
+          mavenOptions: '$(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: $(JavaVersion)
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+
+      - powershell: |
+          # use sources files as a marker to find POM files so we can copy them to the output. The sources.jar file is generally
+          # in a target folder next to the pom.xml file so $_.Directory.Parent should get us the folder that contains the POM.
+          dir -r -i *-sources.jar | % { copy (Join-Path $_.Directory.Parent.FullName "pom.xml") (Join-Path $(Build.ArtifactStagingDirectory) $_.Name.Replace("-sources.jar",".pom")) }
+          dir -r -i *.jar | % { copy $_ $(Build.ArtifactStagingDirectory) }
+        displayName: 'Copy JAR and POM files to artifact staging'
+
+      - task: PublishBuildArtifacts@1
+        displayName: 'Publish Artifacts $(ArtifactName)'
+        inputs:
+          artifactName: '$(ArtifactName)'
+
+  - job: 'Analyze'
+
+    pool:
+      vmImage: 'ubuntu-16.04'
+
+    steps:
+      # sudo is required for pip install, as a console_entrypoint shim needs to be placed in bin
+      - script: |
+          pip install setuptools wheel
+          sudo pip install doc-warden
+          ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/eng/.docsettings.yml
+        displayName: 'Verify Readmes'
+
+      - task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
+        # ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
+        # builds should be sufficient.
+        condition: and(succeededOrFailed(), ne(variables['Build.Reason'], 'PullRequest'))
+        displayName: 'Component Detection'
+
+      # We `install` separately from running `site:site site:stage` so that the `install` brings in the non-shipping-modules,
+      # but we don't include them in the Maven site commands (so that we don't generate reports for the non-shipping modules).
+      - task: Maven@3
+        displayName: 'Install reporting tools'
+        inputs:
+          mavenPomFile: $(pomFile)
+          options: '$(DefaultOptions) -Dinclude-non-shipping-modules -DskipTests -Dgpg.skip'
+          mavenOptions: '$(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: '1.11'
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'install'
+
+      - task: Maven@3
+        displayName: 'Generate Maven project site, including JavaDocs, SpotBugs, and CheckStyle reports'
+        inputs:
+          mavenPomFile: $(pomFile)
+          options: '$(DefaultOptions) -DskipTests -Dgpg.skip'
+          mavenOptions: '$(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: '1.11'
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'site:site site:stage'
+
+      - powershell: |
+          copy -r target/staging $(Build.ArtifactStagingDirectory)
+          copy eng/code-quality-reports/src/main/resources/index.html $(Build.ArtifactStagingDirectory)
+          copy eng/spotbugs-aggregate-report/target/spotbugs/spotbugsXml.html (Join-Path $(Build.ArtifactStagingDirectory) "staging")
+        displayName: 'Copy reports to artifact staging'
+
+      - task: PublishBuildArtifacts@1
+        condition: succeededOrFailed()
+        displayName: 'Publish Report Artifacts'
+        inputs:
+          artifactName: reports
+
+  - job: 'Test'
+
+    strategy:
+      matrix:
+        Linux - Java 8:
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          JavaVersion: '1.8'
+          ProfileFlag: ''
+        macOS - Java 8:
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          JavaVersion: '1.8'
+          ProfileFlag: ''
+        Windows - Java 8:
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          JavaVersion: '1.8'
+          ProfileFlag: ''
+        Linux - Java LTS:
+          OSName: 'Linux'
+          OSVmImage: 'ubuntu-16.04'
+          JavaVersion: '1.11'
+          ProfileFlag: '-Djava-lts'
+        macOS - Java LTS:
+          OSName: 'macOS'
+          OSVmImage: 'macOS-10.13'
+          JavaVersion: '1.11'
+          ProfileFlag: '-Djava-lts'
+        Windows - Java LTS:
+          OSName: 'Windows'
+          OSVmImage: 'vs2017-win2016'
+          JavaVersion: '1.11'
+          ProfileFlag: '-Djava-lts'
+
+    pool:
+      vmImage: $(OSVmImage)
+
+    steps:
+      - task: Maven@3
+        displayName: 'Start Jetty'
+        inputs:
+          mavenPomFile: $(pomFile)
+          options: '$(DefaultOptions) $(ProfileFlag)'
+          mavenOptions: '$(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: $(JavaVersion)
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'jetty:run-forked'
+
+      - task: Maven@3
+        displayName: 'Run tests'
+        inputs:
+          mavenPomFile: $(pomFile)
+          options: '$(DefaultOptions) $(ProfileFlag)'
+          mavenOptions: '-Xmx3072m $(LoggingOptions)'
+          javaHomeOption: 'JDKVersion'
+          jdkVersionOption: $(JavaVersion)
+          jdkArchitectureOption: 'x64'
+          publishJUnitResults: false
+          goals: 'test'
+
+      - task: PublishTestResults@2
+        condition: succeededOrFailed()
+        inputs:
+          mergeTestResults: true
+          testRunTitle: '$(OSName) on Java $(JavaVersion)'

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,40 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: "[BUG]"
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+***Exception or Stack Trace***
+Add the exception log and stack trace if available
+
+**To Reproduce**
+Steps to reproduce the behavior:
+
+***Code Snippet***
+Add the code snippet that causes the issue.
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Setup (please complete the following information):**
+ - OS: [e.g. iOS]
+ - IDE : [e.g. IntelliJ]
+ - Version of the Library used
+
+**Additional context**
+Add any other context about the problem here.
+
+**Information Checklist**
+Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
+- [ ] Bug Description Added
+- [ ] Repro Steps Added
+- [ ] Setup information Added

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,25 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: "[FEATURE REQ]"
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.
+
+**Information Checklist**
+Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
+- [ ] Description Added
+- [ ] Expected solution specified