Skip to content

Commit

Permalink
Fix issue #217 Table: QueryTablesOptions.Query not fully used.
Browse files Browse the repository at this point in the history
  • Loading branch information
Albert Cheng committed Apr 6, 2012
1 parent 564d8aa commit f338598
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -380,31 +380,15 @@ public QueryTablesResult queryTables() throws ServiceException {

@Override
public QueryTablesResult queryTables(QueryTablesOptions options) throws ServiceException {

Query query = options.getQuery();
Query query = new Query();
String nextTableName = options.getNextTableName();
String prefix = options.getPrefix();

if (prefix != null) {
// Append Max char to end '{' is 1 + 'z' in AsciiTable ==> upperBound is prefix + '{'
Filter prefixFilter = Filter.and(Filter.ge(Filter.litteral("TableName"), Filter.constant(prefix)),
Filter.le(Filter.litteral("TableName"), Filter.constant(prefix + "{")));

// a new query is needed if prefix alone is passed in
if (query == null) {
query = new Query();
}

// examine the existing filter on the query
if (query.getFilter() == null) {
// use the prefix filter if the query filter is null
query.setFilter(prefixFilter);
}
else {
// combine and use the prefix filter if the query filter exists
Filter combinedFilter = Filter.and(query.getFilter(), prefixFilter);
query.setFilter(combinedFilter);
}
query.setFilter(prefixFilter);
}

WebResource webResource = getResource(options).path("Tables");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,8 @@

public class QueryTablesOptions extends TableServiceOptions {
private String nextTableName;
private Query query;
private String prefix;

public Query getQuery() {
return query;
}

public QueryTablesOptions setQuery(Query query) {
this.query = query;
return this;
}

public String getNextTableName() {
return nextTableName;
}
Expand Down

0 comments on commit f338598

Please sign in to comment.