Resolve PR feedback

Azure · Mar 31, 2021 · b90815e · b90815e
1 parent 09d4ea5
commit b90815e
Show file tree

Hide file tree

Showing 8 changed files with 42 additions and 10 deletions.
diff --git a/eng/common/TestResources/New-TestResources.ps1 b/eng/common/TestResources/New-TestResources.ps1
@@ -632,7 +632,7 @@ is passed to the ARM template as 'tenantId'.
 Optional subscription ID to use for new resources when logging in as a
 provisioner. You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId

diff --git a/eng/common/TestResources/New-TestResources.ps1.md b/eng/common/TestResources/New-TestResources.ps1.md
@@ -231,7 +231,7 @@ Optional subscription ID to use for new resources when logging in as a
 provisioner.
 You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId
@@ -477,7 +477,7 @@ Accept wildcard characters: False
 ```
 
 ### CommonParameters
-This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
+This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](https://go.microsoft.com/fwlink/?LinkID=113216).
 
 ## INPUTS
 

diff --git a/eng/common/TestResources/README.md b/eng/common/TestResources/README.md
@@ -134,6 +134,8 @@ Install-Module platyPS -Scope CurrentUser -Force
 New-MarkdownHelp -Command .\New-TestResources.ps1 -OutputFolder . -Force
 ```
 
+After the markdown files are generated, please make sure all "http" URIs use "https".
+
 PowerShell markdown documentation created with [platyPS][].
 
   [New-TestResources.ps1]: https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/TestResources/New-TestResources.ps1.md

diff --git a/eng/common/TestResources/Remove-TestResources.ps1 b/eng/common/TestResources/Remove-TestResources.ps1
@@ -229,6 +229,7 @@ $exitActions.Invoke()
 <#
 .SYNOPSIS
 Deletes the resource group deployed for a service directory from Azure.
+
 .DESCRIPTION
 Removes a resource group and all its resources previously deployed using
 New-TestResources.ps1.
@@ -237,37 +238,48 @@ you will be asked to log in with Connect-AzAccount. Alternatively, you (or a
 build pipeline) can pass $ProvisionerApplicationId and
 $ProvisionerApplicationSecret to authenticate a service principal with access to
 create resources.
+
 .PARAMETER BaseName
 A name to use in the resource group and passed to the ARM template as 'baseName'.
 This will delete the resource group named 'rg-<baseName>'
+
 .PARAMETER ResourceGroupName
 The name of the resource group to delete.
+
 .PARAMETER TenantId
 The tenant ID of a service principal when a provisioner is specified.
+
 .PARAMETER SubscriptionId
 Optional subscription ID to use when deleting resources when logging in as a
 provisioner. You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId
 will be used for subsequent operations that are specific to a subscription.
+
 .PARAMETER ProvisionerApplicationId
 A service principal ID to provision test resources when a provisioner is specified.
+
 .PARAMETER ProvisionerApplicationSecret
 A service principal secret (password) to provision test resources when a provisioner is specified.
+
 .PARAMETER ServiceDirectory
 A directory under 'sdk' in the repository root - optionally with subdirectories
 specified - in which to discover pre removal script named 'remove-test-resources-pre.json'.
+
 .PARAMETER Environment
 Name of the cloud environment. The default is the Azure Public Cloud
 ('PublicCloud')
+
 .PARAMETER Force
 Force removal of resource group without asking for user confirmation
+
 .EXAMPLE
 Remove-TestResources.ps1 keyvault -Force
 Use the currently logged-in account to delete the resources created for Key Vault testing.
+
 .EXAMPLE
 Remove-TestResources.ps1 `
     -ResourceGroupName "${env:AZURE_RESOURCEGROUP_NAME}" `
@@ -279,4 +291,5 @@ Remove-TestResources.ps1 `
 When run in the context of an Azure DevOps pipeline, this script removes the
 resource group whose name is stored in the environment variable
 AZURE_RESOURCEGROUP_NAME.
+
 #>
diff --git a/eng/common/TestResources/Remove-TestResources.ps1.md b/eng/common/TestResources/Remove-TestResources.ps1.md
@@ -139,7 +139,7 @@ Optional subscription ID to use when deleting resources when logging in as a
 provisioner.
 You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId
@@ -294,7 +294,7 @@ Accept wildcard characters: False
 ```
 
 ### CommonParameters
-This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
+This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](https://go.microsoft.com/fwlink/?LinkID=113216).
 
 ## INPUTS
 

diff --git a/eng/common/TestResources/Update-TestResources.cmd b/eng/common/TestResources/Update-TestResources.cmd
@@ -0,0 +1,17 @@
+@echo off
+
+REM Copyright (c) Microsoft Corporation. All rights reserved.
+REM Licensed under the MIT License.
+
+setlocal
+
+for /f "usebackq delims=" %%i in (`where pwsh 2^>nul`) do (
+    set _cmd=%%i
+)
+
+if "%_cmd%"=="" (
+    echo Error: PowerShell not found. Please visit https://github.com/powershell/powershell for install instructions.
+    exit /b 2
+)
+
+call "%_cmd%" -NoLogo -NoProfile -File "%~dpn0.ps1" %*
diff --git a/eng/common/TestResources/Update-TestResources.ps1 b/eng/common/TestResources/Update-TestResources.ps1
@@ -177,7 +177,7 @@ The name of the resource group to update.
 Optional subscription ID to use when deleting resources when logging in as a
 provisioner. You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId
@@ -203,4 +203,4 @@ Update-TestResources.ps1 -ResourceGroupName rg-userkeyvault -Subscription fa9c69
 Update the 'rg-userkeyvault' resource group to be deleted after 48
 hours from now if a clean-up script is running against the subscription 'fa9c6912-f641-4226-806c-5139584b89ca'.
 
-#>
+#>
diff --git a/eng/common/TestResources/Update-TestResources.ps1.md b/eng/common/TestResources/Update-TestResources.ps1.md
@@ -102,7 +102,7 @@ Optional subscription ID to use when deleting resources when logging in as a
 provisioner.
 You can also use Set-AzContext if not provisioning.
 
-If you do not specify a SubscriptionId and are not logged in, once will be
+If you do not specify a SubscriptionId and are not logged in, one will be
 automatically selected for you by the Connect-AzAccount cmdlet.
 
 Once you are logged in (or were previously), the selected SubscriptionId
@@ -142,7 +142,7 @@ Accept wildcard characters: False
 ```
 
 ### CommonParameters
-This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
+This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](https://go.microsoft.com/fwlink/?LinkID=113216).
 
 ## INPUTS