Merge pull request #390 from gcheng/morecore

move some classes that should belong to core to the core.
Azure · Jul 31, 2013 · 4134be0 · 4134be0
2 parents f178e8a + abc8d3c
commit 4134be0
Show file tree

Hide file tree

Showing 21 changed files with 71 additions and 54 deletions.
diff --git a/microsoft-azure-api/src/main/java/com/microsoft/windowsazure/services/blob/Exports.java b/microsoft-azure-api/src/main/java/com/microsoft/windowsazure/services/blob/Exports.java
@@ -16,10 +16,10 @@
 
 import com.microsoft.windowsazure.services.blob.implementation.BlobExceptionProcessor;
 import com.microsoft.windowsazure.services.blob.implementation.BlobRestProxy;
-import com.microsoft.windowsazure.services.blob.implementation.ISO8601DateConverter;
 import com.microsoft.windowsazure.services.blob.implementation.SharedKeyFilter;
 import com.microsoft.windowsazure.services.blob.implementation.SharedKeyLiteFilter;
 import com.microsoft.windowsazure.services.core.Builder;
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
 import com.microsoft.windowsazure.services.core.UserAgentFilter;
 
 public class Exports implements Builder.Exports {

diff --git a/.../java/com/microsoft/windowsazure/services/blob/implementation/BlobOperationRestProxy.java b/.../java/com/microsoft/windowsazure/services/blob/implementation/BlobOperationRestProxy.java
@@ -67,6 +67,7 @@
 import com.microsoft.windowsazure.services.blob.models.SetBlobPropertiesOptions;
 import com.microsoft.windowsazure.services.blob.models.SetBlobPropertiesResult;
 import com.microsoft.windowsazure.services.blob.models.SetContainerMetadataOptions;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.ServiceException;
 import com.microsoft.windowsazure.services.core.ServiceFilter;
 import com.microsoft.windowsazure.services.core.utils.CommaStringBuilder;

diff --git a/.../src/main/java/com/microsoft/windowsazure/services/blob/implementation/BlobRestProxy.java b/.../src/main/java/com/microsoft/windowsazure/services/blob/implementation/BlobRestProxy.java
@@ -21,6 +21,7 @@
 
 import com.microsoft.windowsazure.services.blob.BlobConfiguration;
 import com.microsoft.windowsazure.services.blob.BlobContract;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.ServiceFilter;
 import com.microsoft.windowsazure.services.core.UserAgentFilter;
 import com.microsoft.windowsazure.services.core.utils.pipeline.HttpURLConnectionClient;

diff --git a/...java/com/microsoft/windowsazure/services/blob/implementation/ContainerACLDateAdapter.java b/...java/com/microsoft/windowsazure/services/blob/implementation/ContainerACLDateAdapter.java
@@ -2,22 +2,24 @@
  * Copyright Microsoft Corporation
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *    http://www.apache.org/licenses/LICENSE-2.0
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
  * 
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
 package com.microsoft.windowsazure.services.blob.implementation;
 
 import java.util.Date;
 
 import javax.xml.bind.annotation.adapters.XmlAdapter;
 
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
+
 /*
  * JAXB adapter for a "not quite" ISO 8601 date time element
  */

diff --git a/...rc/main/java/com/microsoft/windowsazure/services/blob/implementation/SharedKeyFilter.java b/...rc/main/java/com/microsoft/windowsazure/services/blob/implementation/SharedKeyFilter.java
@@ -26,6 +26,7 @@
 
 import com.microsoft.windowsazure.services.blob.BlobConfiguration;
 import com.microsoft.windowsazure.services.blob.implementation.SharedKeyUtils.QueryParam;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.utils.pipeline.EntityStreamingListener;
 import com.sun.jersey.api.client.ClientHandlerException;
 import com.sun.jersey.api.client.ClientRequest;

diff --git a/...ain/java/com/microsoft/windowsazure/services/blob/implementation/SharedKeyLiteFilter.java b/...ain/java/com/microsoft/windowsazure/services/blob/implementation/SharedKeyLiteFilter.java
@@ -24,6 +24,7 @@
 
 import com.microsoft.windowsazure.services.blob.BlobConfiguration;
 import com.microsoft.windowsazure.services.blob.implementation.SharedKeyUtils.QueryParam;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.utils.pipeline.EntityStreamingListener;
 import com.sun.jersey.api.client.ClientHandlerException;
 import com.sun.jersey.api.client.ClientRequest;

diff --git a/...re-api/src/main/java/com/microsoft/windowsazure/services/blob/models/AccessCondition.java b/...re-api/src/main/java/com/microsoft/windowsazure/services/blob/models/AccessCondition.java
@@ -16,7 +16,7 @@
 
 import java.util.Date;
 
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateConverter;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 
 /**
  * Represents a set of access conditions for operations that use storage services.

diff --git a/...ure-api/src/main/java/com/microsoft/windowsazure/services/blob/models/BlobProperties.java b/...ure-api/src/main/java/com/microsoft/windowsazure/services/blob/models/BlobProperties.java
@@ -19,7 +19,7 @@
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateAdapter;
+import com.microsoft.windowsazure.services.core.RFC1123DateAdapter;
 
 /**
  * Represents the HTML properties and system properties that may be set on a blob.

diff --git a/...i/src/main/java/com/microsoft/windowsazure/services/blob/models/ListContainersResult.java b/...i/src/main/java/com/microsoft/windowsazure/services/blob/models/ListContainersResult.java
@@ -26,7 +26,7 @@
 
 import com.microsoft.windowsazure.services.blob.BlobContract;
 import com.microsoft.windowsazure.services.blob.implementation.MetadataAdapter;
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateAdapter;
+import com.microsoft.windowsazure.services.core.RFC1123DateAdapter;
 
 /**
  * A wrapper class for the response returned from a Blob Service REST API List Containers operation. This is returned by

diff --git a/.../implementation/ISO8601DateConverter.java → ...e/services/core/ISO8601DateConverter.java b/.../implementation/ISO8601DateConverter.java → ...e/services/core/ISO8601DateConverter.java
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package com.microsoft.windowsazure.services.blob.implementation;
+package com.microsoft.windowsazure.services.core;
 
 import java.text.DateFormat;
 import java.text.ParseException;

diff --git a/...ob/implementation/RFC1123DateAdapter.java → ...ure/services/core/RFC1123DateAdapter.java b/...ob/implementation/RFC1123DateAdapter.java → ...ure/services/core/RFC1123DateAdapter.java
@@ -2,17 +2,17 @@
  * Copyright Microsoft Corporation
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *    http://www.apache.org/licenses/LICENSE-2.0
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
  * 
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
-package com.microsoft.windowsazure.services.blob.implementation;
+package com.microsoft.windowsazure.services.core;
 
 import java.util.Date;
 

diff --git a/.../implementation/RFC1123DateConverter.java → ...e/services/core/RFC1123DateConverter.java b/.../implementation/RFC1123DateConverter.java → ...e/services/core/RFC1123DateConverter.java
@@ -2,17 +2,17 @@
  * Copyright Microsoft Corporation
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *    http://www.apache.org/licenses/LICENSE-2.0
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
  * 
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
-package com.microsoft.windowsazure.services.blob.implementation;
+package com.microsoft.windowsazure.services.core;
 
 import java.text.DateFormat;
 import java.text.ParseException;

diff --git a/...ain/java/com/microsoft/windowsazure/services/media/implementation/MediaBlobRestProxy.java b/...ain/java/com/microsoft/windowsazure/services/media/implementation/MediaBlobRestProxy.java
@@ -19,7 +19,7 @@
 
 import com.microsoft.windowsazure.services.blob.BlobContract;
 import com.microsoft.windowsazure.services.blob.implementation.BlobOperationRestProxy;
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateConverter;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.ServiceFilter;
 import com.sun.jersey.api.client.Client;
 

diff --git a/...rc/main/java/com/microsoft/windowsazure/services/queue/implementation/QueueRestProxy.java b/...rc/main/java/com/microsoft/windowsazure/services/queue/implementation/QueueRestProxy.java
@@ -21,7 +21,7 @@
 import javax.inject.Inject;
 import javax.inject.Named;
 
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateConverter;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.ServiceException;
 import com.microsoft.windowsazure.services.core.ServiceFilter;
 import com.microsoft.windowsazure.services.core.UserAgentFilter;

diff --git a/...pi/src/main/java/com/microsoft/windowsazure/services/queue/models/ListMessagesResult.java b/...pi/src/main/java/com/microsoft/windowsazure/services/queue/models/ListMessagesResult.java
@@ -22,7 +22,7 @@
 import javax.xml.bind.annotation.XmlRootElement;
 import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateAdapter;
+import com.microsoft.windowsazure.services.core.RFC1123DateAdapter;
 import com.microsoft.windowsazure.services.queue.QueueContract;
 
 /**

diff --git a/...pi/src/main/java/com/microsoft/windowsazure/services/queue/models/PeekMessagesResult.java b/...pi/src/main/java/com/microsoft/windowsazure/services/queue/models/PeekMessagesResult.java
@@ -22,7 +22,7 @@
 import javax.xml.bind.annotation.XmlRootElement;
 import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateAdapter;
+import com.microsoft.windowsazure.services.core.RFC1123DateAdapter;
 import com.microsoft.windowsazure.services.queue.QueueContract;
 
 /**

diff --git a/.../main/java/com/microsoft/windowsazure/services/table/implementation/AtomReaderWriter.java b/.../main/java/com/microsoft/windowsazure/services/table/implementation/AtomReaderWriter.java
@@ -1,11 +1,11 @@
 /**
  * Copyright Microsoft Corporation
- *
+ * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  * http://www.apache.org/licenses/LICENSE-2.0
- *
+ * 
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -29,7 +29,7 @@
 import javax.xml.stream.XMLStreamReader;
 import javax.xml.stream.XMLStreamWriter;
 
-import com.microsoft.windowsazure.services.blob.implementation.ISO8601DateConverter;
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
 import com.microsoft.windowsazure.services.core.utils.DateFactory;
 import com.microsoft.windowsazure.services.table.EdmValueConverter;
 import com.microsoft.windowsazure.services.table.models.Entity;
@@ -84,7 +84,8 @@ public void write(XMLStreamWriter writer) throws XMLStreamException {
 
                     if (value != null) {
                         writer.writeCharacters(value);
-                    } else {
+                    }
+                    else {
                         writer.writeAttribute("m:null", "true");
                     }
 
@@ -107,7 +108,8 @@ public List<TableEntry> parseTableEntries(InputStream stream) {
                 // Process "entry" elements only
                 if (isStartElement(xmlr, "entry")) {
                     result.add(parseTableEntry(xmlr));
-                } else {
+                }
+                else {
                     nextSignificant(xmlr);
                 }
             }
@@ -116,7 +118,8 @@ public List<TableEntry> parseTableEntries(InputStream stream) {
             expect(xmlr, XMLStreamConstants.END_DOCUMENT);
 
             return result;
-        } catch (XMLStreamException e) {
+        }
+        catch (XMLStreamException e) {
             throw new RuntimeException(e);
         }
     }
@@ -130,7 +133,8 @@ public TableEntry parseTableEntry(InputStream stream) {
             expect(xmlr, XMLStreamConstants.END_DOCUMENT);
 
             return result;
-        } catch (XMLStreamException e) {
+        }
+        catch (XMLStreamException e) {
             throw new RuntimeException(e);
         }
     }
@@ -147,7 +151,8 @@ public List<Entity> parseEntityEntries(InputStream stream) {
                 // Process "entry" elements only
                 if (isStartElement(xmlr, "entry")) {
                     result.add(parseEntityEntry(xmlr));
-                } else {
+                }
+                else {
                     nextSignificant(xmlr);
                 }
             }
@@ -156,7 +161,8 @@ public List<Entity> parseEntityEntries(InputStream stream) {
             expect(xmlr, XMLStreamConstants.END_DOCUMENT);
 
             return result;
-        } catch (XMLStreamException e) {
+        }
+        catch (XMLStreamException e) {
             throw new RuntimeException(e);
         }
     }
@@ -170,7 +176,8 @@ public Entity parseEntityEntry(InputStream stream) {
             expect(xmlr, XMLStreamConstants.END_DOCUMENT);
 
             return result;
-        } catch (XMLStreamException e) {
+        }
+        catch (XMLStreamException e) {
             throw new RuntimeException(e);
         }
     }
@@ -220,7 +227,8 @@ private InputStream generateEntry(PropertiesWriter propertiesWriter) {
             writer.close();
 
             return new ByteArrayInputStream(stream.toByteArray());
-        } catch (XMLStreamException e) {
+        }
+        catch (XMLStreamException e) {
             throw new RuntimeException(e);
         }
     }
@@ -235,7 +243,8 @@ private TableEntry parseTableEntry(XMLStreamReader xmlr) throws XMLStreamExcepti
                 Map<String, Property> properties = parseEntryProperties(xmlr);
 
                 result.setName((String) properties.get("TableName").getValue());
-            } else {
+            }
+            else {
                 nextSignificant(xmlr);
             }
         }
@@ -254,7 +263,8 @@ private Entity parseEntityEntry(XMLStreamReader xmlr) throws XMLStreamException
         while (!isEndElement(xmlr, "entry")) {
             if (isStartElement(xmlr, "properties")) {
                 result.setProperties(parseEntryProperties(xmlr));
-            } else {
+            }
+            else {
                 nextSignificant(xmlr);
             }
         }
@@ -326,7 +336,8 @@ private void expect(XMLStreamReader xmlr, int eventType, String localName) throw
     private String encodeNumericCharacterReference(String value) {
         if (value == null) {
             return null;
-        } else {
+        }
+        else {
             char[] charArray = value.toCharArray();
             StringBuffer stringBuffer = new StringBuffer();
             for (int index = 0; index < charArray.length; index++) {

diff --git a/...va/com/microsoft/windowsazure/services/table/implementation/DefaultEdmValueConverter.java b/...va/com/microsoft/windowsazure/services/table/implementation/DefaultEdmValueConverter.java
@@ -20,7 +20,7 @@
 
 import javax.inject.Inject;
 
-import com.microsoft.windowsazure.services.blob.implementation.ISO8601DateConverter;
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
 import com.microsoft.windowsazure.services.table.EdmValueConverter;
 import com.microsoft.windowsazure.services.table.models.EdmType;
 import com.sun.jersey.core.util.Base64;

diff --git a/...rc/main/java/com/microsoft/windowsazure/services/table/implementation/TableRestProxy.java b/...rc/main/java/com/microsoft/windowsazure/services/table/implementation/TableRestProxy.java
@@ -39,8 +39,8 @@
 import javax.xml.stream.XMLStreamException;
 import javax.xml.stream.XMLStreamReader;
 
-import com.microsoft.windowsazure.services.blob.implementation.ISO8601DateConverter;
-import com.microsoft.windowsazure.services.blob.implementation.RFC1123DateConverter;
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
+import com.microsoft.windowsazure.services.core.RFC1123DateConverter;
 import com.microsoft.windowsazure.services.core.ServiceException;
 import com.microsoft.windowsazure.services.core.ServiceFilter;
 import com.microsoft.windowsazure.services.core.UserAgentFilter;

diff --git a/...ementation/ISO8601DateConverterTests.java → ...vices/core/ISO8601DateConverterTests.java b/...ementation/ISO8601DateConverterTests.java → ...vices/core/ISO8601DateConverterTests.java
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package com.microsoft.windowsazure.services.blob.implementation;
+package com.microsoft.windowsazure.services.core;
 
 import static org.junit.Assert.*;
 

diff --git a/.../java/com/microsoft/windowsazure/services/table/implementation/AtomReaderWriterTests.java b/.../java/com/microsoft/windowsazure/services/table/implementation/AtomReaderWriterTests.java
@@ -22,7 +22,7 @@
 
 import org.junit.Test;
 
-import com.microsoft.windowsazure.services.blob.implementation.ISO8601DateConverter;
+import com.microsoft.windowsazure.services.core.ISO8601DateConverter;
 import com.microsoft.windowsazure.services.core.utils.DefaultDateFactory;
 import com.microsoft.windowsazure.services.table.IntegrationTestBase;
 import com.microsoft.windowsazure.services.table.models.TableEntry;