Skip to content

Commit

Permalink
Merge pull request #1134 from anuchandy/gen-compute
Browse files Browse the repository at this point in the history
Removing unnecessary LangDefs and addressing sample review comments
  • Loading branch information
Martin Sawicki authored Sep 29, 2016
2 parents 7969de4 + fc46b9b commit 1f498a7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
*/
package com.microsoft.azure.management.compute.implementation;

import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.compute.VirtualMachineSize;

/**
* The implementation for {@link VirtualMachineSize}.
*/
@LangDefinition
class VirtualMachineSizeImpl implements VirtualMachineSize {
private VirtualMachineSizeInner innerModel;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
package com.microsoft.azure.management.compute.implementation;

import com.microsoft.azure.PagedList;
import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.compute.VirtualMachineSize;
import com.microsoft.azure.management.compute.VirtualMachineSizes;
import com.microsoft.azure.management.resources.fluentcore.arm.Region;
Expand All @@ -15,7 +14,6 @@
/**
* The implementation for {@link VirtualMachineSizes}.
*/
@LangDefinition
class VirtualMachineSizesImpl
extends ReadableWrappersImpl<VirtualMachineSize, VirtualMachineSizeImpl, VirtualMachineSizeInner>
implements VirtualMachineSizes {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.microsoft.azure.management.compute.VirtualMachineOffer;
import com.microsoft.azure.management.compute.VirtualMachinePublisher;
import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.compute.Sku;
import com.microsoft.azure.management.compute.VirtualMachineImagesInSku;
import com.microsoft.azure.management.compute.VirtualMachineSku;
Expand All @@ -11,7 +10,6 @@
/**
* The implementation for {@link Sku}.
*/
@LangDefinition
class VirtualMachineSkuImpl
implements VirtualMachineSku {
private final VirtualMachineOffer offer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
package com.microsoft.azure.management.compute.implementation;

import com.microsoft.azure.PagedList;
import com.microsoft.azure.management.apigeneration.LangDefinition;
import com.microsoft.azure.management.compute.VirtualMachineOffer;
import com.microsoft.azure.management.compute.VirtualMachineSkus;
import com.microsoft.azure.management.compute.VirtualMachineSku;
Expand All @@ -15,7 +14,6 @@
/**
* The implementation for {@link VirtualMachineSkus}.
*/
@LangDefinition
class VirtualMachineSkusImpl
extends ReadableWrappersImpl<VirtualMachineSku, VirtualMachineSkuImpl, VirtualMachineImageResourceInner>
implements VirtualMachineSkus {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ public final class ManageVirtualMachinesInParallel {
*/
public static void main(String[] args) {

final int vmCount = 2;
final String rgName = ResourceNamer.randomResourceName("rgCOMV", 24);
final int vmCount = 10;
final String rgName = ResourceNamer.randomResourceName("rgCOPP", 24);
final String networkName = ResourceNamer.randomResourceName("vnetCOMV", 24);
final String storageAccountName = ResourceNamer.randomResourceName("stgCOMV", 20);
final String userName = "tirekicker";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

package com.microsoft.azure.management.compute.samples;
package com.microsoft.azure.management.network.samples;

import com.microsoft.azure.Azure;
import com.microsoft.azure.management.compute.KnownLinuxVirtualMachineImage;
Expand All @@ -28,24 +28,24 @@
import java.util.List;

/**
* Azure Compute sample for managing virtual machines -
* Azure Network sample for managing virtual machines with virtual network -
* Create a virtual network with two Subnets – frontend and backend
* Frontend allows HTTP in and denies Internet out
* Backend denies Internet in and Internet out
* Create m Linux virtual machines in the frontend
* Create m Windows virtual machines in the backend.
*/
public final class ManageVirtualMachinesInParallel2 {
public final class ManageVirtualMachinesInParallelWithNetwork {

/**
* Main entry point.
* @param args the parameters
*/
public static void main(String[] args) {

final int frontendVmCount = 5;
final int backendVmCount = 5;
final String rgName = ResourceNamer.randomResourceName("rgCOMV", 24);
final int frontendVmCount = 10;
final int backendVmCount = 10;
final String rgName = ResourceNamer.randomResourceName("rgNEPP", 24);
final String frontEndNSGName = ResourceNamer.randomResourceName("fensg", 24);
final String backEndNSGName = ResourceNamer.randomResourceName("bensg", 24);
final String networkName = ResourceNamer.randomResourceName("vnetCOMV", 24);
Expand Down Expand Up @@ -263,6 +263,6 @@ public static void main(String[] args) {
}
}

private ManageVirtualMachinesInParallel2() {
private ManageVirtualMachinesInParallelWithNetwork() {
}
}

0 comments on commit 1f498a7

Please sign in to comment.