-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Introduce new method createCommunicationIdentifier(from rawId:) #1312
Merged
tjprescott
merged 24 commits into
Azure:main
from
JoshuaLai:feature/swift_createCommunicationIdentifier
Aug 24, 2022
Merged
[Feature] Introduce new method createCommunicationIdentifier(from rawId:) #1312
tjprescott
merged 24 commits into
Azure:main
from
JoshuaLai:feature/swift_createCommunicationIdentifier
Aug 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…promote shared behaviour
… with other platforms
…icationIdentifier from rawId
ghost
added
the
Communication
label
Jul 12, 2022
JoshuaLai
requested review from
waynemo,
mpodwysocki,
DominikMe,
tjprescott and
petrsvihlik
July 12, 2022 21:50
petrsvihlik
suggested changes
Jul 15, 2022
sdk/communication/AzureCommunicationCommon/Source/Identifiers.swift
Outdated
Show resolved
Hide resolved
tjprescott
reviewed
Jul 15, 2022
sdk/communication/AzureCommunicationCommon/Source/CommunicationIdentifierFactory.h
Show resolved
Hide resolved
…com:JoshuaLai/azure-sdk-for-ios into feature/swift_createCommunicationIdentifier
petrsvihlik
approved these changes
Jul 21, 2022
tjprescott
requested changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding temporarily while we let the archboard weigh-in.
this is blocking #1335 |
mpodwysocki
approved these changes
Aug 24, 2022
tjprescott
approved these changes
Aug 24, 2022
tjprescott
requested changes
Aug 24, 2022
sdk/communication/AzureCommunicationCommon/Source/Identifiers.swift
Outdated
Show resolved
Hide resolved
tjprescott
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing new method to serialize and deserialize the communication identifier the raw id.
Follow up from feedback from PR(#1255)
Swift Interface:
ObjC Interface: