Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v38.0.0 #6576

Merged
merged 418 commits into from
Jan 7, 2020
Merged

v38.0.0 #6576

merged 418 commits into from
Jan 7, 2020

Conversation

ArcturusZhang
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • The PR targets the latest branch.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

AutorestCI and others added 30 commits September 5, 2019 10:48
@AutorestCI @ArcturusZhang
[AutoPR] securityinsights/resource-manager (Azure#5683)
3df8fdb 
* Generated from 878390cbb0806c9194cc9ceaed923284d2d8f2ac (Azure#5288)

Fix mistake

* [AutoPR securityinsights/resource-manager] SecurityInsights: Investigation swagger updates (Azure#5292)

* Generated from 27abe226e56bd1a6d13985c9bc8871148a8c34ad

Merge branch 'master' into InvestigationSwagger

* Generated from ebb1f1f5bdab7f12639fbee775adf16611d092ad

removed cases changes (will be in another PR)

* Generated from ab899e75a364a5b6dbf21370c1db65b769094ec8

removed bookmarkEntity from entities api (currently not supported)

* [AutoPR securityinsights/resource-manager] Adding alertRuleTemplates swagger spec to securityInsight (Azure#5504)

* Generated from d731243f4645a2df9c8389e10e93be04ea78a620

Add alertRuleTemplates endpoint to securityInsight

* Generated from d09f26c587fddd31fa13cb3d94d7a9bbe8d58ec8

fix merge conflict

* Generated from efe14acff06c754692f29bffee877f29edb68b89

Bookmarks swagger updates

* Generated from 07393c4915496b1768a08c5f408b05cdb2a27f10

fix typos

* Generated from 98fdd0347934e59d39a7b6f803f170933c96d199

fix typo

* Generated from e00e65896ca96c4c814528fa286e3f6e2d534122 (Azure#5682)

sort definitions and parameters by ABC

* Resolved conflict manually
@AutorestCI @ArcturusZhang
[AutoPR] network/resource-manager (Azure#5692)
6da95fa 
* Generated from 3b992f9396f9c0bc7e34b11696efcffafa92575a (Azure#5297)

add network package-2019-06 to Go SDK

* Generated from 36ba645d97091ead19fa04d57595069d73491c7e (Azure#5511)

Update PE/PLS

* Generated from ec578e180c4515be63046f0b0991d7b9547e657d (Azure#5522)

Update description of "location" in serviceTags.json

* [AutoPR network/resource-manager] chore: jsonfmt network (Azure#5514)

* Generated from 2c363ba11150b1894650db67b5d4a03166b95afd

chore: jsonfmt network

* Generated from 2c363ba11150b1894650db67b5d4a03166b95afd

chore: jsonfmt network

* Generated from 92006e420d65cb70e4b93bc5850af575da4efb78 (Azure#5637)

Mark "provisioningState" as read-only

* [AutoPR network/resource-manager] Add missing read-only property "outboundRules" in LoadBalancer specs (Azure#5647)

* Generated from 658cfc162acc76fd35b81aa42b29406d9ba013cb

Add missing read-only property "outboundRules" in LoadBalancer specs

* Generated from 658cfc162acc76fd35b81aa42b29406d9ba013cb

Add missing read-only property "outboundRules" in LoadBalancer specs
@AutorestCI @ArcturusZhang
[AutoPR] storage/resource-manager (Azure#5695)
bc96b83 
* Generated from 3acbc3b4106db3097de5be5e4df47afb38d51ec0 (Azure#5473)

Use cors definition from blob.json

* Generated from 94667089d429b4f1aca38e60f85b13f5c0039219 (Azure#5580)

Align File swagger with the Blob swagger
@AutorestCI @ArcturusZhang
Generated from 8264dcc49e0bc239013cd76ce9664f83f1041967 (Azure#5678)
234ca02 
Update Kusto.json with TSVE data format
@AutorestCI @ArcturusZhang
[AutoPR eventgrid/data-plane] Create KeyVault.json (Azure#5546)
10d3530 
* Generated from 66c76158ca650e8f4bf0ff082bc5428e2544c457

Update readme with KeyVault.json

* Generated from 7d4a2513c50a216bfe9cbf6a6f769d460d7211f4

Revert "Update readme with KeyVault.json"

This reverts commit 66c76158ca650e8f4bf0ff082bc5428e2544c457.

* Generated from 44674ab5aabc591e8dd6b10d326071e8fa3ccd49

Update readme.md
@AutorestCI @ArcturusZhang
[AutoPR] compute/resource-manager (Azure#5706)
d33cbe0 
* [AutoPR compute/resource-manager] removing non-ascii character (Azure#5325)

* Generated from 090b727225320af61034c7278c3ccf51dcbef8a2

removing non-ascii character

* Generated from 56ccb1151588cff87c1c92eee0e6c56e42c7f2f4

corrected the description

* [AutoPR compute/resource-manager] Add terminate profile and scheduled events profile to Microsoft.Compute (Azure#5310)

* Generated from 9bb1d5b7f21a0e03e97ce3817554307244d45422

Correct definition format

* Generated from 49bbc9237680dc7963f9d24f7cde1d05e8f14260

Merge branch 'master' into dev/szimmer/AddTerminateProfile

* [AutoPR compute/resource-manager] Add missing Gallery Application API in 2019-07-01 version (Azure#5354)

* Generated from 01293ebd64fa96d11d30d9b0ef1391cbe8e62443

Add missing Gallery Application API in 2019-07-01 version

* Generated from 6637309053b80e0b62b01f1c240d72749e30f1c2

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

* [AutoPR compute/resource-manager] add HyperVGeneation in GetVMImage (Azure#5344)

* Generated from 4b3b012a4c684afd2e931bb2ac4c01bbf894eec4

add HyperVGeneation in SharedVMImageVersion

* Generated from c34793bd9910de785d31e7bf8e6da1fd7e30de8b

reuse HyperVGenerationType

* Generated from c34793bd9910de785d31e7bf8e6da1fd7e30de8b

reuse HyperVGenerationType

*  compute/resource-manager] Swagger: Allowing for VMSS reference during

VM creation (Azure#5408)

* Generated from 547a98bc34516d8788adff951ebd929d8d5125ae

Swagger: Allowing for VMSS reference during VM creation

* Generated from 2723517c6c29f1c6945bdf05b9c4e42f85159011

fixing typo

* [AutoPR compute/resource-manager] [Do not merge yet] DiskRP Swagger changes for 2019-03-01 (Azure#5398)

* Generated from a308b6604cb4bfdb8085d78f998aa3718cf9ae36

adding unique id

* Generated from b7b0ecc49d6694ea41c66ef9936f05da9bae38f3

fixing typo

* Generated from 34c96075059bf06bf052835f6f405b2d0649d1b7

removing diskSizeBytes from snapshot\disk update properties and adding a unique id for disk properties

* Generated from 1ad0c2e2dd85dad2a363072eb4cdcbe250e1522b

pr comments

* Generated from 4f5dbad04518d0674689ac2a2388ea823d28cadf

pr comments

* [AutoPR compute/resource-manager] Adding low priority and variable pricing feature for standalone VMs. Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. (Azure#5523)

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 9d5e30df16e3ea43cb3b21b5f5264373d8ed2397 (Azure#5596)

updating an incorrect description for uploadsizebytes

* Generated from 79b1099e7cf1d0a077c2f5b38b4c83408b97a59b (Azure#5652)

Add missing $expand parameter to AvSet list by subscription API
@AutorestCI @ArcturusZhang
[AutoPR] storage/resource-manager (Azure#5707)
202e4e8 
* Generated from 3acbc3b4106db3097de5be5e4df47afb38d51ec0 (Azure#5473)

Use cors definition from blob.json

* Generated from 94667089d429b4f1aca38e60f85b13f5c0039219 (Azure#5580)

Align File swagger with the Blob swagger

* [AutoPR storage/resource-manager] Add change feed properties to 2019-04-01 Storage. (Azure#5621)

* Generated from 774367438889ac553def1957b72b8ba63ad877e5

Add change feed properties to 2019-04-01 Storage.

Add change feed properties to Storage Blob Services.

* Generated from 774367438889ac553def1957b72b8ba63ad877e5

Add change feed properties to 2019-04-01 Storage.

Add change feed properties to Storage Blob Services.
@AutorestCI @ArcturusZhang
Generated from 34d744550227bee7b380604d38fc1de6c9af6397 (Azure#5708)
b6279b1 
Update netapp.json
@AutorestCI @ArcturusZhang
Merge pull request Azure#5714 from Azure/restapi_auto_compute/resourc…
996c11b 
…e-manager

[AutoPR] compute/resource-manager
@ArcturusZhang
Update swagger_to_sdk_config.json
414c1e5 
Update autorest.go to new version
@AutorestCI @ArcturusZhang
Generated from 5ea5da031f993e6dd8061f42abbea77d58e66020
7fabec8 
Clarify KeyVault time as seconds since Unix epoch
@AutorestCI @ArcturusZhang
Generated from b621ede227cd29651b1712782d964373fc2da6ec (Azure#5717)
063ee1d 
Quick fix
@AutorestCI @ArcturusZhang
Generated from 4eb71094207cc3188dfa1d604325731362a555a5
01db230 
updating readmes
@ArcturusZhang
feature: support PutBlockFromURL API:
e1a2795 
https://docs.microsoft.com/en-us/rest/api/storageservices/put-block-from-url
@AutorestCI @ArcturusZhang
Generated from 18efd73807c1182800e0521f67e1e5ae2ee70394
8514ef6 
added missing packages to compute release
@AutorestCI @ArcturusZhang
[AutoPR] compute/resource-manager (Azure#5721)
060afc9 
* [AutoPR compute/resource-manager] removing non-ascii character (Azure#5325)

* Generated from 090b727225320af61034c7278c3ccf51dcbef8a2

removing non-ascii character

* Generated from 56ccb1151588cff87c1c92eee0e6c56e42c7f2f4

corrected the description

* [AutoPR compute/resource-manager] Add terminate profile and scheduled events profile to Microsoft.Compute (Azure#5310)

* Generated from 9bb1d5b7f21a0e03e97ce3817554307244d45422

Correct definition format

* Generated from 49bbc9237680dc7963f9d24f7cde1d05e8f14260

Merge branch 'master' into dev/szimmer/AddTerminateProfile

* [AutoPR compute/resource-manager] Add missing Gallery Application API in 2019-07-01 version (Azure#5354)

* Generated from 01293ebd64fa96d11d30d9b0ef1391cbe8e62443

Add missing Gallery Application API in 2019-07-01 version

* Generated from 6637309053b80e0b62b01f1c240d72749e30f1c2

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

* [AutoPR compute/resource-manager] add HyperVGeneation in GetVMImage (Azure#5344)

* Generated from 4b3b012a4c684afd2e931bb2ac4c01bbf894eec4

add HyperVGeneation in SharedVMImageVersion

* Generated from c34793bd9910de785d31e7bf8e6da1fd7e30de8b

reuse HyperVGenerationType

* Generated from c34793bd9910de785d31e7bf8e6da1fd7e30de8b

reuse HyperVGenerationType

*  compute/resource-manager] Swagger: Allowing for VMSS reference during

VM creation (Azure#5408)

* Generated from 547a98bc34516d8788adff951ebd929d8d5125ae

Swagger: Allowing for VMSS reference during VM creation

* Generated from 2723517c6c29f1c6945bdf05b9c4e42f85159011

fixing typo

* [AutoPR compute/resource-manager] [Do not merge yet] DiskRP Swagger changes for 2019-03-01 (Azure#5398)

* Generated from a308b6604cb4bfdb8085d78f998aa3718cf9ae36

adding unique id

* Generated from b7b0ecc49d6694ea41c66ef9936f05da9bae38f3

fixing typo

* Generated from 34c96075059bf06bf052835f6f405b2d0649d1b7

removing diskSizeBytes from snapshot\disk update properties and adding a unique id for disk properties

* Generated from 1ad0c2e2dd85dad2a363072eb4cdcbe250e1522b

pr comments

* Generated from 4f5dbad04518d0674689ac2a2388ea823d28cadf

pr comments

* [AutoPR compute/resource-manager] Adding low priority and variable pricing feature for standalone VMs. Added priority, eviction policy and billing profile to VirtualMachineProperties. Also, adding optional billing profile to VMSS Create and Update APIs. (Azure#5523)

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 10d72ee6c882c170c44d54928e192a421d1032a1

fixed typo

* Generated from 9d5e30df16e3ea43cb3b21b5f5264373d8ed2397 (Azure#5596)

updating an incorrect description for uploadsizebytes

* Generated from 79b1099e7cf1d0a077c2f5b38b4c83408b97a59b (Azure#5652)

Add missing $expand parameter to AvSet list by subscription API

* [AutoPR compute/resource-manager] Add VMScaleSet ScaleIn Policy (Azure#5606)

* Generated from 5968c8d1d8f53fcce6b11bc71e4be3c6bc550617

Add VMScaleSet ScaleIn Policy

Adds VMScaleSet ScaleIn policy that is supported with the 2019-03-01 header but not included in Swagger

* Generated from 17a6aebc538afafffc9ce87f083fc07592a6b5c3

Update compute.json

Fix indentation
@AutorestCI @ArcturusZhang
[AutoPR] datafactory/resource-manager (Azure#5730)
ea3b8ea 
* Generated from 5e1bb35d5c3314d8f4fead76c3d69a2522be026b (Azure#5651)

Update review comments

* [AutoPR datafactory/resource-manager] support Express Custom Setup (Azure#5536)

* Generated from 696212c605edef333cba0f0e86d42ba344f4fc42

address the comments

* Generated from 4de64a2262df8e2e971620c95f7c3a2ba91d49d9

address comments

* Generated from fc0bdde313743dbbed8e8c506dd9e07107d04142

Merge branch 'master' into ivan/support-express-custom-setup-for-manged-ir

* Generated from fc0bdde313743dbbed8e8c506dd9e07107d04142

Merge branch 'master' into ivan/support-express-custom-setup-for-manged-ir

* [AutoPR datafactory/resource-manager] [Data Factory]Add ORC Dataset/Copy Source/Copy Sink (Azure#5611)

* Generated from 864a2b3827b7237d7cb60d77069b693dcbaf7001

[DataFactory]Add support for ORC dataset

* Generated from 864a2b3827b7237d7cb60d77069b693dcbaf7001

[DataFactory]Add support for ORC dataset

* Fix CI failure and conflict

* Generated from b07009df21da758efcb13fbbd25ce9e450751586 (Azure#5729)

[DataFactory] Update Databricks linked service swagger related to warm pools.
@AutorestCI @ArcturusZhang
Generated from 4d7873fcb2eb980ac1eacad015893bd5634a5a37 (Azure#5735)
a934945 
[ACR] Adding scopemap spec file for new SDK build

For releasing ScopeMap and Token features, we need to retrieve models from the scopemap spec file. 
The existing SDK version doesn't incorporate changes from the scopemap spec file. 

Requesting a new SDK build. Please suggest changes if deemed necessary.
@AutorestCI @ArcturusZhang
Generated from 68ccfd97b6bd4b29219d6988342451fff61b7031 (Azure#5737)
ee3fc46 
[Batch] Update documentation around app packages
@AutorestCI @ArcturusZhang
[AutoPR servicebus/resource-manager] ServiceBus: added NetworkRuleSet…
3a0ef95 
…s list API (Azure#5624)

* Generated from 26fbb00e498d34206afb040c7c9eb7b79fa3fd5e

added NetworkRuleSets list API

* Generated from 87e06617e7103a97295b2fe25f4a47990371b397

added x-ms-pageable and formating

* Generated from 2f83e3fb7917b9f6301fea15cf45e3e3fbeac7bb

removed readonly for compatibilityLevel
@AutorestCI @ArcturusZhang
[AutoPR cosmos-db/resource-manager] Add short url for all api resourc…
5e45933 
…es (Azure#5448)

* Generated from 6b485b2047ec2cc073363b94a56778b108912940

Add short url for all api resources

* Generated from d0f3adbb4578d7a5569d29a683663bf4772af38a

Correct GremlinResources_ spell

* Generated from a05be8787ab7cc8346e38c01ccbd45731ad95169

Add new api version

* Generated from 72880ac9171c7118002c56eb2152265bb41442ba

Fix spell error
@AutorestCI @ArcturusZhang
Generated from 1ca1ae2151cd7248fac7b82624424ce63383a28a (Azure#5745)
c383392 
fix: Double word "the" in datalake-analytics
@AutorestCI @ArcturusZhang
[AutoPR] datafactory/resource-manager (Azure#5751)
183f8b1 
* Generated from 5e1bb35d5c3314d8f4fead76c3d69a2522be026b (Azure#5651)

Update review comments

* [AutoPR datafactory/resource-manager] support Express Custom Setup (Azure#5536)

* Generated from 696212c605edef333cba0f0e86d42ba344f4fc42

address the comments

* Generated from 4de64a2262df8e2e971620c95f7c3a2ba91d49d9

address comments

* Generated from fc0bdde313743dbbed8e8c506dd9e07107d04142

Merge branch 'master' into ivan/support-express-custom-setup-for-manged-ir

* Generated from fc0bdde313743dbbed8e8c506dd9e07107d04142

Merge branch 'master' into ivan/support-express-custom-setup-for-manged-ir

* [AutoPR datafactory/resource-manager] [Data Factory]Add ORC Dataset/Copy Source/Copy Sink (Azure#5611)

* Generated from 864a2b3827b7237d7cb60d77069b693dcbaf7001

[DataFactory]Add support for ORC dataset

* Generated from 864a2b3827b7237d7cb60d77069b693dcbaf7001

[DataFactory]Add support for ORC dataset

* Fix CI failure and conflict

* Generated from b07009df21da758efcb13fbbd25ce9e450751586 (Azure#5729)

[DataFactory] Update Databricks linked service swagger related to warm pools.

* Generated from 5cc2c54ac1ba7f41fd2426ff39df46f785ce55f2 (Azure#5748)

Add a clearer description.
@AutorestCI @ArcturusZhang
Generated from 94dbf0ac2518371373cf8f2eb74bba657b1e7b90 (Azure#5414)
11474dc 
Orphan property removed
@AutorestCI @ArcturusZhang
Generated from 33d64b558114a9a861b82dc17518e359758d1688 (Azure#5686)
6265993 
Fix SpellCheck Swagger Specification
@AutorestCI @ArcturusZhang
Generated from 81fb55e8252598b44b1d5ee4db527eacba725546 (Azure#5687)
26d44dd 
Fix Local Search Swagger
@ArcturusZhang
Generated from latest specs of network
232e6ff
@AutorestCI @ArcturusZhang
Generated from af961540f808cb651ddb1dbac08619eafc06330e (Azure#5789)
e0ad0b7 
Add 2019-07 version to network go code generation
@AutorestCI @ArcturusZhang
Generated from 1baa9a51ee00db62b006b2081d2811297d48d3d4 (Azure#5761)
612e70a 
Updated 2019-02-01-preview api version to include  operation.g
@AutorestCI @ArcturusZhang
Generated from 7837d7e037f47c5a2414e0a241e1472c960ff055 (Azure#5744)
049ef53 
fix: Double word "the" in automation
SDK Automation and others added 22 commits December 17, 2019 11:03
@ArcturusZhang
Generated from da48a54cf0068154a6ac389f781c008887731b92
8533454 
Remove readonly
@ArcturusZhang
Update code generator version
50ba845
@ArcturusZhang
containerService2017-07-01
55062c8
@ArcturusZhang
containerService2017-08-31
ba6958c
@ArcturusZhang
containerServices2017-09-30
0c5a4c0
@ArcturusZhang
container service 2018-03-31
7604618
@ArcturusZhang
container service 2019-02-01
f3db8c4
@ArcturusZhang
container service 2019-04-30
40b23e3
@ArcturusZhang
container service 2019-06-01
ff5ac46
@ArcturusZhang
container service 2019-08-01
6eea2d0
@ArcturusZhang
container service 2019-10-01
dc03efe
@ArcturusZhang
container service 2019-11-01
d60c16c
@ArcturusZhang
container service 2018-08-01-preview
82a03b5
@ArcturusZhang
container service 2018-09-30-preview
e48002b
@ArcturusZhang
container service 2019-09-30-preview
a796c5a
@ArcturusZhang
deploymentmanager 2019-11-01-preview
25730fd
@ArcturusZhang
policyinsights 2018-07-01-preview
ab3a949
@ArcturusZhang
policyinsights 2019-10-01
377b84b
@ArcturusZhang
Generate profile
a2474c5
@ArcturusZhang
Generated from latest swagger
06ef354
@ArcturusZhang
Merge branch 'latest'
26f30a1
@ArcturusZhang
v38.0.0
5bf1033
@azuresdkci
Copy link

Can one of the admins verify this patch?

@ArcturusZhang
Copy link
Member Author

Hi @jhendrixMSFT I have two codegen related questions about this major version release code.

  1. It seems that the APIVersion change is taking effect. But the position of APIVersion seems unstable, is there any solution that we could stabilize the location of APIVersion parameter in the parameter list?
    You can take this as an example.
  2. What kind of service will have an APIVersion string as their parameters? Is there a rule of this?

@ArcturusZhang
Copy link
Member Author

The third question is that do we have default values for those APIVersion parameters? Or the customer must explicitly assign one? This may cause some inconvenience when using the SDK.

@jhendrixMSFT
Copy link
Member

I looked at the swagger, the ordering has this inconsistency there too. While we could enforce a certain ordering I'm hesitant to do so (maybe it's ok, I haven't thought too deeply about it).
I don't think there's a rule, it up to how the authors wrote the swagger.
I don't know anything about this API, so I don't know if having some kind of default value makes sense.

@ArcturusZhang
Copy link
Member Author

ArcturusZhang commented Dec 27, 2019 •
edited
Loading

I looked at the swagger, the ordering has this inconsistency there too. While we could enforce a certain ordering I'm hesitant to do so (maybe it's ok, I haven't thought too deeply about it).
I don't think there's a rule, it up to how the authors wrote the swagger.
I don't know anything about this API, so I don't know if having some kind of default value makes sense.

So is API version must add to this method, is because of the API version parameter in swagger has a "x-ms-parameter-location": "method", attribute?
I think we can release this major version in this way. This parameter ordering problem is not the first time (last time I know is v37.0.0)
Or if we setup a rule for how those parameter orders it will be good, i think, to keep those different methods consistent.

@ArcturusZhang ArcturusZhang merged commit 2e62f97 into Azure:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArcturusZhang @azuresdkci @jhendrixMSFT @AutorestCI @stevegore