Check errors

.travis.yml

@@ -10,6 +10,7 @@ install:
   - go get -u golang.org/x/net/context
   - go get -u github.com/HewlettPackard/gas
   - go get -u gopkg.in/godo.v2/cmd/godo
+  - go get -u github.com/kisielk/errcheck
   - export GO15VENDOREXPERIMENT=1
   - glide install
 
@@ -30,3 +31,4 @@ script:
   - go vet ./management/...
   - test -z "$(golint ./Gododir/... | tee /dev/stderr)"
   - go vet ./Gododir/...
+  - set -e; for v in ./arm/... ./datalake-store/... ./Gododir/... ./management/... ./storage/...; do (errcheck -ignoretests "$v" | grep -v 'Close()' | tee /dev/stderr); done

management/examples/example.go

@@ -48,13 +48,19 @@ func main() {
 
 	fmt.Println("Create virtual machine")
 	role := vmutils.NewVMConfiguration(dnsName, vmSize)
-	vmutils.ConfigureDeploymentFromPlatformImage(
+	if err := vmutils.ConfigureDeploymentFromPlatformImage(
 		&role,
 		vmImage,
 		fmt.Sprintf("http://%s.blob.core.windows.net/%s/%s.vhd", storageAccount, dnsName, dnsName),
-		"")
-	vmutils.ConfigureForLinux(&role, dnsName, userName, userPassword)
-	vmutils.ConfigureWithPublicSSH(&role)
+		""); err != nil {
+		panic(err)
+	}
+	if err := vmutils.ConfigureForLinux(&role, dnsName, userName, userPassword); err != nil {
+		panic(err)
+	}
+	if err := vmutils.ConfigureWithPublicSSH(&role); err != nil {
+		panic(err)
+	}
 
 	fmt.Println("Deploy")
 	operationID, err := virtualmachine.NewClient(client).

management/vmutils/extensions.go

@@ -58,7 +58,9 @@ func AddAzureDockerVMExtensionConfiguration(role *vm.Role, dockerPort int, versi
 		return fmt.Errorf(errParamNotSpecified, "role")
 	}
 
-	ConfigureWithExternalPort(role, "docker", dockerPort, dockerPort, vm.InputEndpointProtocolTCP)
+	if err := ConfigureWithExternalPort(role, "docker", dockerPort, dockerPort, vm.InputEndpointProtocolTCP); err != nil {
+		return err
+	}
 
 	publicConfiguration, err := createDockerPublicConfig(dockerPort)
 	if err != nil {

storage/blob.go

@@ -537,9 +537,7 @@ func (b BlobStorageClient) SetContainerPermissions(container string, containerPe
 	}
 
 	if resp != nil {
-		defer func() {
-			err = resp.body.Close()
-		}()
+		defer resp.body.Close()
 
 		if resp.statusCode != http.StatusOK {
 			return errors.New("Unable to set permissions")
@@ -575,9 +573,7 @@ func (b BlobStorageClient) GetContainerPermissions(container string, timeout int
 	// containerAccess. Blob, Container, empty
 	containerAccess := resp.headers.Get(http.CanonicalHeaderKey(ContainerAccessHeader))
 
-	defer func() {
-		err = resp.body.Close()
-	}()
+	defer resp.body.Close()
 
 	var out AccessPolicy
 	err = xmlUnmarshal(resp.body, &out.SignedIdentifiersList)
@@ -1479,7 +1475,10 @@ func (b BlobStorageClient) GetBlobSASURIWithSignedIPAndProtocol(container, name
 		return "", err
 	}
 
-	sig := b.client.computeHmac256(stringToSign)
+	sig, err := b.client.computeHmac256(stringToSign)
+	if err != nil {
+		return "", err
+	}
 	sasParams := url.Values{
 		"sv":  {b.client.apiVersion},
 		"se":  {signedExpiry},

storage/client.go

@@ -234,9 +234,12 @@ func (c Client) GetFileService() FileServiceClient {
 	return FileServiceClient{c}
 }
 
-func (c Client) createAuthorizationHeader(canonicalizedString string) string {
-	signature := c.computeHmac256(canonicalizedString)
-	return fmt.Sprintf("%s %s:%s", "SharedKey", c.getCanonicalizedAccountName(), signature)
+func (c Client) createAuthorizationHeader(canonicalizedString string) (string, error) {
+	signature, err := c.computeHmac256(canonicalizedString)
+	if err != nil {
+		return "", err
+	}
+	return fmt.Sprintf("%s %s:%s", "SharedKey", c.getCanonicalizedAccountName(), signature), nil
 }
 
 func (c Client) getAuthorizationHeader(verb, url string, headers map[string]string) (string, error) {
@@ -246,7 +249,7 @@ func (c Client) getAuthorizationHeader(verb, url string, headers map[string]stri
 	}
 
 	canonicalizedString := c.buildCanonicalizedString(verb, headers, canonicalizedResource)
-	return c.createAuthorizationHeader(canonicalizedString), nil
+	return c.createAuthorizationHeader(canonicalizedString)
 }
 
 func (c Client) getStandardHeaders() map[string]string {
@@ -500,7 +503,10 @@ func (c Client) createSharedKeyLite(url string, headers map[string]string) (stri
 	}
 	strToSign := headers["x-ms-date"] + "\n" + can
 
-	hmac := c.computeHmac256(strToSign)
+	hmac, err := c.computeHmac256(strToSign)
+	if err != nil {
+		return "", err
+	}
 	return fmt.Sprintf("SharedKeyLite %s:%s", c.accountName, hmac), nil
 }
 

storage/client_test.go

@@ -244,5 +244,7 @@ func (s *StorageClientSuite) Test_createAuthorizationHeader(c *chk.C) {
 
 	canonicalizedString := `foobarzoo`
 	expected := `SharedKey foo:h5U0ATVX6SpbFX1H6GNuxIMeXXCILLoIvhflPtuQZ30=`
-	c.Assert(cli.createAuthorizationHeader(canonicalizedString), chk.Equals, expected)
+	ah, err := cli.createAuthorizationHeader(canonicalizedString)
+	c.Assert(err, chk.IsNil)
+	c.Assert(ah, chk.Equals, expected)
 }

storage/file.go

@@ -250,7 +250,6 @@ func (f FileServiceClient) ListDirsAndFiles(path string, params ListDirsAndFiles
 	if err != nil {
 		return out, err
 	}
-
 	defer resp.body.Close()
 	err = xmlUnmarshal(resp.body, &out)
 	return out, err
@@ -302,7 +301,6 @@ func (f FileServiceClient) ListShares(params ListSharesParameters) (ShareListRes
 	if err != nil {
 		return out, err
 	}
-
 	defer resp.body.Close()
 	err = xmlUnmarshal(resp.body, &out)
 	return out, err
@@ -323,7 +321,7 @@ func (f FileServiceClient) listContent(path string, params url.Values, extraHead
 	}
 
 	if err = checkRespCode(resp.statusCode, []int{http.StatusOK}); err != nil {
-		resp.body.Close()
+		_ = resp.body.Close()
 		return nil, err
 	}
 
@@ -400,7 +398,6 @@ func (f FileServiceClient) modifyRange(path string, bytes io.Reader, fileRange F
 	if err != nil {
 		return err
 	}
-
 	defer resp.body.Close()
 	return checkRespCode(resp.statusCode, []int{http.StatusCreated})
 }
@@ -423,7 +420,7 @@ func (f FileServiceClient) GetFile(path string, fileRange *FileRange) (*FileStre
 	}
 
 	if err = checkRespCode(resp.statusCode, []int{http.StatusOK, http.StatusPartialContent}); err != nil {
-		resp.body.Close()
+		defer resp.body.Close()
 		return nil, err
 	}
 

storage/queue.go

@@ -319,7 +319,7 @@ func (c QueueServiceClient) DeleteMessage(queue, messageID, popReceipt string) e
 	if err != nil {
 		return err
 	}
-	defer resp.body.Close()
+	deferresp.body.Close()
 	return checkRespCode(resp.statusCode, []int{http.StatusNoContent})
 }
 

storage/table.go

@@ -56,7 +56,9 @@ func (c *TableServiceClient) QueryTables() ([]AzureTable, error) {
 	}
 
 	buf := new(bytes.Buffer)
-	buf.ReadFrom(resp.body)
+	if _, err := buf.ReadFrom(resp.body); err != nil {
+		return nil, err
+	}
 
 	var respArray queryTablesResponse
 	if err := json.Unmarshal(buf.Bytes(), &respArray); err != nil {

storage/table_entities.go

@@ -147,10 +147,7 @@ func (c *TableServiceClient) execTable(table AzureTable, entity TableEntity, spe
 
 	headers["Content-Length"] = fmt.Sprintf("%d", buf.Len())
 
-	var err error
-	var resp *odataResponse
-
-	resp, err = c.client.execTable(method, uri, headers, &buf)
+	resp, err := c.client.execTable(method, uri, headers, &buf)
 
 	if err != nil {
 		return 0, err
@@ -327,8 +324,12 @@ func deserializeEntity(retType reflect.Type, reader io.Reader) ([]TableEntity, e
 		}
 
 		// Reset PartitionKey and RowKey
-		tEntries[i].SetPartitionKey(pKey)
-		tEntries[i].SetRowKey(rKey)
+		if err := tEntries[i].SetPartitionKey(pKey); err != nil {
+			return nil, err
+		}
+		if err := tEntries[i].SetRowKey(rKey); err != nil {
+			return nil, err
+		}
 	}
 
 	return tEntries, nil

storage/util.go

@@ -15,10 +15,12 @@ import (
 	"time"
 )
 
-func (c Client) computeHmac256(message string) string {
+func (c Client) computeHmac256(message string) (string, error) {
 	h := hmac.New(sha256.New, c.accountKey)
-	h.Write([]byte(message))
-	return base64.StdEncoding.EncodeToString(h.Sum(nil))
+	if _, err := h.Write([]byte(message)); err != nil {
+		return "", fmt.Errorf("Failed computing to hmac256 : %v", err)
+	}
+	return base64.StdEncoding.EncodeToString(h.Sum(nil)), nil
 }
 
 func currentTimeRfc1123Formatted() string {