Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

management: check x509 decoding errors #427

Merged
merged 1 commit into from
Oct 25, 2016
Merged

management: check x509 decoding errors #427

merged 1 commit into from
Oct 25, 2016

Conversation

mischief
Copy link
Contributor

errors should not be ignored in this codebase, and https://github.com/kisielk/errcheck should probably be run over the whole repo.

this caused a hard to debug auth problem where i mishandled certificate decoding from azureProfile.json from the CLI.

@mcardosos
Copy link
Contributor

LGTM, @jhendrixMSFT ?

@jhendrixMSFT
Copy link
Member

Yep looks good, thanks for the fix. :)

@jhendrixMSFT jhendrixMSFT merged commit 0884ebb into Azure:master Oct 25, 2016
@jhendrixMSFT jhendrixMSFT mentioned this pull request Oct 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mischief @mcardosos @jhendrixMSFT @msftclas