Expose the public IP address of virtual machines #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public IP name and timeout were provided, but there was no way to get the actual address.
|
Hi @kklin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
thank you for the pull request @kklin. |
daemonfire300
added a commit
to daemonfire300/azure-sdk-for-go
that referenced
this pull request
Jun 4, 2016
* Add support for creating Clients from a previously read settings file * refactoring * more refactoring to remove some xml duplication * Reconcile publishSettings methods * can have more than 1 WinRMListener when creating machine * adding util functions for setting WinRM endpoints * adding integration test for windows box with winrm * tidy up some debug code * fixing casing error picked up by go lint * running go fmt * Alpha of ARM packages Signed-off-by: Brendan Dixon <[email protected]> * Made examples a package Signed-off-by: Brendan Dixon <[email protected]> * Removed runner Signed-off-by: Brendan Dixon <[email protected]> * Switched to using log for errors Signed-off-by: Brendan Dixon <[email protected]> * Removed unnecessary return statements Signed-off-by: Brendan Dixon <[email protected]> * Made more use of log.Fatalf Signed-off-by: Brendan Dixon <[email protected]> * Converted examples to use Test for execution Signed-off-by: Brendan Dixon <[email protected]> * Corrected HTTP handling Signed-off-by: Brendan Dixon <[email protected]> * Exposing UnexpectedStatusCodeError.Got to support (fixes Azure#197) * Queue - Get and Set metadata with user defined data (fixes Azure#200, fixes Azure#199) * storage/file: Preliminary support for File Service Support for CreateShare/DeleteShare calls. * Add CreateBlockBlobWithData and CreateBlockBlobFromReader * Add SetBlobMetadata and GetBlobMetadata * Remove redundant CreateBlockBlobWithData. Add godoc hint about size limits. * Use userDefinedMetadataHeaderPrefix const for "x-ms-meta-" * Use HasPrefix instead of string slices * Clarify test case * Note size limits for PutBlock* * Fix typos in auth header names * v0.1.0-beta Signed-off-by: Brendan Dixon <[email protected]> * Added golint / govet to Travis CI for arm packages Signed-off-by: Brendan Dixon <[email protected]> * Fix typo in arm/README.md Fix typo in arm/README.md * Fix typo * Use x/crypto/pkcs12 instead of Azure repo * Use the Content-Length header if it is set The Content-Length header is never used by the Go runtime. Instead, the ContentLength field on the request struct is used to set the header when writing the actual request. This field is only set for certain types of io.Readers. Azure storage signatures include the Content-Length header, hence, it needs to be respected, even if the io.Reader is some other type that is not recognized by the Go runtime. Signed-off-by: Paul Meyer <[email protected]> * Adding AddRole method so that this bug can be fixed: hashicorp/terraform#3568 * Added comment with REST API reference - we need to add the other API referenced in that link to azure-sdk-for-go * hashicorp/terraform#3568 * fix golint issue & go fmt * DeleteRole REST API needs a query parameter to also delete the VHD disk from storage while deleting the VM. Added the parameter * Adding boolean parameter to DeleteRole based on which the disk will be deleted or retained - as per review comment on this pull request - Azure#237 * Address outstanding issues, upgrade to latest Swagger Signed-off-by: Brendan Dixon <[email protected]> * A little bit better markdown * Corrected client and enum name generation Signed-off-by: Brendan Dixon <[email protected]> * godep update github.com/Azure/go-autorest to 2.0.0 * Fixing PR Azure#187 * Make DeleteDisk return synchronously * Fix DataDiskConfigurations XML unmarshalling in VMImage entity * Allow filtering when listing VM images * Add DeleteVirtualMachineImage * Distinguish between deploying Public VM images and User VM images * Follow management API endpoint redirects * Added QueryParameterName and QueryParameterValue to Error func output * gofmt * add PutBlockWithContentType * remove PutBlockWithContentType, add extraHeaders to PutBlockWithLength and PutPage * Revision 2016-01-01 * fix blob_test.go * add extraHeaders to CreateBlockBlobFromReader * fix test * Updated DNS to latest Swager * fix storage test * [glide] remove godeps * [glide] remove Godep path rewriting * [glide] glide init * [glide] gofmt everything * [glide] fix .travis.yml * updated for glide.yaml * ran 'glide up' to update dependenices to latest * Update CHANGELOG.md * updated CHANGELOG.md * updated CHANGELOG.md * version change * Updated for godoc * Updated for godoc * Updated for the godoc comments * [storage] Adds support for Append Blobs Adds PutAppendBlob and AppendBlock methods Changes DefaultAPIVersion to 2015-02-21 Updates storage client signing code to support newer version Signed-off-by: Brian Bland <[email protected]> * Add support of PostShudownAction for shutdown vm * updated for long-running operations support * Remove variedic argument in vw.ShutdownRole * Fix for review comments * Remove unused packages of patched legacy stdlibs * Polling changes (go-autorest v6.0.0 updates) * glide.lock changed * Fix travis build * Pin travis to go:1.6 * example/helpers/helpers.go * ARM examples updated * add support for extra headers in AppendBlock * add support for extra headers in PutPage * Version updated to 2.0.0-beta * Reuse http.Client across requests, and allow caller to provide its own. Enables connection sharing with http keepalive, and allows callers to use Go's other http client/transport features like request timeouts. * Allow caller to provide headers for DeleteBlob methods. * Remove tests for If-[Un]modified-Since headers that Azure seems to ignore. * Update for Polling and Asynchronous calls Uses go-autorest version v7.0.0. * Revert "Update for Polling and Asynchronous calls" * Update polling logic for long-running operations Uses go-autorest version v7.0.2. Handle polling for both Asynchronous and Location headers. Add cancel channel argument to cancel polling. * Uses go-autorest v7.0.3 * storage: Add BlobPrefixes and Delimiter to BlobListResponse Per the MSDN docs, these would be required in order to traverse the blob storage as if it were a file system. As with this example: ``` func traveseBlobs(client storage.BlobStorageClient, prefix string, depth int) { blobParams := storage.ListBlobsParameters{ Delimiter: "/", Prefix: prefix, } response, err := client.ListBlobs(accountContainer, blobParams) checkError(err) pad := strings.Repeat(" ", depth*2) // Print folders folders := response.BlobPrefixes for _, folder := range folders { folderWithoutParent := strings.TrimPrefix(folder, prefix) fmt.Printf("%sd %s\n", pad, folderWithoutParent) traveseBlobs(client, folder, depth+1) } // Print blob names blobs := response.Blobs for _, blob := range blobs { blobWithoutParent := strings.TrimPrefix(blob.Name, prefix) fmt.Printf("%s- %s\n", pad, blobWithoutParent) } } ``` This would produce (with correct blobs in storage): ``` d root/ d folderA/ - fileAA.txt - fileAB.txt - fileAC.txt d folderB/ d subfolderC/ - fileBCA.txt - fileBA.txt - fileBB.txt - fileBC.txt d some_folder/ d some_subfolder/ - xxx.txt - bar.txt ``` * set location to UTC to meet formatting requirements of Shared Access Signatures * Better error messages for long running operation failures. Uses go-autorest v7.0.4. * SDK version update * Add extra headers support to GetBlobRange * List blob metadata (Azure#319) storage: Add Metadata to Blob in BlobListResponse. * storage: Azure Table implementation (Azure#217) Initial implementation for Azure Table Storage * Implement xml.Marshaler for BlobMetadata type Implement xml.Marshaler for BlobMetadata type * Expose the public IP address of virtual machines (Azure#325) The public IP name and timeout were provided, but there was no way to get the actual address. * Add support for extraHeaders in SetBlobMetadata (Azure#327) * Adding LeaseStatus to storage.BlobProperties (Azure#336) * Adding LeaseStatus to storage.BlobProperties Particularly in case of a Page Blob, this property is useful in determining if the VHD is being used by a VM or not. * Fixing Xml tag name for LeaseStatus Blob property (Fixes Azure#335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public IP name and timeout were provided, but there was no way to
get the actual address.