remove pkg.go.dev link in readme #23708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
weshaggard
approved these changes
Nov 7, 2024
lirenhe
approved these changes
Nov 12, 2024
glecaros
pushed a commit
that referenced
this pull request
Nov 19, 2024
* remove pkg.go.dev link in readme * fix changelog
glecaros
added a commit
that referenced
this pull request
Dec 3, 2024
* hash+gen * Adding in MessageAttachmentToolDefinition * Accidental copy/paste * Updating doc comment for MessageAttachmentToolDefinition * Update docindex.yml to use Python 3.11 (#23719) Co-authored-by: Daniel Jurek <[email protected]> * Refresh OIDC token in azadmin test resources scripts (#23722) * remove pkg.go.dev link in readme (#23708) * remove pkg.go.dev link in readme * fix changelog * upgrade typesspec-go (#23720) * [azopenai] Inference changes for 2024-10-01-preview (#23672) * update for 1.2.0 release (#23728) * Sync eng/common directory with azure-sdk-tools for PR 9328 (#23692) * ensure that ChangedServices value within the generated pr diff is always properly an array of strings * upload the changed services as an attachment named AdditionalTags in save-package-properties.yml, to allow PipelineWitness to tag public builds during log processing --------- Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> * refine typespec release tool (#23735) * Added permissions & resourcetype parameters in listblob response (#23687) * one * Add permissions in ListBlobsIncludeItems * Add permissions in ListBlobsIncludeItems * Appending the value to swagger * Added Owner,Group,Permissions,Acl,ResourceType in ListBlob Response * [Storage] Prep for stg 95 GA release (#23742) * Prep for stg 95 GA release * Update CHANGELOG.md format for changelog * Add SparseCheckoutPaths to archetype-typespec-emitter.yml (#23740) Co-authored-by: Wei Hu <[email protected]> * [azopenai] Update azopenai changelog. (#23732) * Fix missing stress matrix display name filter (#23726) Co-authored-by: Ben Broderick Phillips <[email protected]> * update date (#23746) * [azopenai] non-existing deployments fail in a different way now. (#23747) * Increment package version after release of ai/azopenai (#23750) * [Release] sdk/resourcemanager/hybridcompute/armhybridcompute/2.1.0-beta.1 generation from spec commit: 63d530d0def1c624f5d42d39170ff4ac196522e2 (#23753) * Increment package version after release of security/keyvault/azadmin (#23749) * Update azopenai* to use hardcoded variable group config (#23748) * Update azopenai* to use hardcoded variable group config * Remove bicep template for ai services * [Release] sdk/resourcemanager/networkcloud/armnetworkcloud/1.2.0-beta.1 generation from spec commit: 4e46346c63935bace7e24f806b4b084f2589d660 (#23757) * Add helpers to log a GitHub "notice" (#23764) Co-authored-by: Mike Harder <[email protected]> * Increment package version after release of storage/azdatalake (#23745) * Increment package version after release of storage/azblob (#23744) * Increment package version after release of storage/azfile (#23743) * batching adjustments for create-prjobmatrix (#23773) Co-authored-by: Scott Beddall <[email protected]> * changelog * updated version * Update sdk/ai/azopenaiassistants/CHANGELOG.md Co-authored-by: Wes Haggard <[email protected]> * updated --------- Co-authored-by: ripark <[email protected]> Co-authored-by: Richard Park <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Chenjie Shi <[email protected]> Co-authored-by: Ashley Stanton-Nurse <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: ashruti-msft <[email protected]> Co-authored-by: tanyasethi-msft <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Grace Wilcox <[email protected]> Co-authored-by: Judy Liu <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem facing:
We have a package link in all our Go SDK packages’ readme.md file. This link is designed to let customers easy to visit the package page in pkg.go.dev from the source code repo.
Also, we have a ci verification that will check if each link in the doc file is valid. Then the problem came. When we release the first beta or any first major version (v2+), the link page is not available before the release tag has been added.
So, in PR or even release pipeline, the ci job will fail.
Decision:
After discussion, we decided to remove the link based on the fact that the link provides minimal value.
Other changes in this PR are from auto-format of md file.