[azeventhubs] Fixing a bug where a cancelled recovery could result in a perpetually broken client #23337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 15, 2024 10:31
…loop and prevent our recovery from happening. This simplifies the overall logic and should be just fine - some of the cases it was trying to handle were mostly related to idleness, and trying to move the bulk of the failures _before_ the `fn` callback, but this should be more or less equivalent while also handling the error immediately. I've got a couple of tests to ensure that some of the important bits are there (partial failure still leads to link recovery). Also, updated stress tests to include pipefail, which makes sure that, if the underlying test fails, the script _exits_ instead of potentially reporting okay because `tee` happened to work :) Also, the stress tests were incorrectly using the test credential, and we can't/don't use that in stress testing.
…l function, instead of the interface function.
richardpark-msft
requested review from
chlowell and
jhendrixMSFT
as code owners
jhendrixMSFT
approved these changes
Aug 15, 2024
|
/azp run go - azeventhubs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a customer issue where they cancel in the middle of our retry loop and prevent our recovery from happening.
This simplifies the overall logic and should be just fine - some of the cases it was trying to handle aren't needed anymore because of changes in the recovery code, etc...
Also, updated stress tests to include pipefail, which makes sure that, if the underlying test fails, the script exits instead of potentially reporting okay because
teehappened to work :) Also, the stress tests were incorrectly using the test credential, and we can't/don't use that in stress testing.Fixes #23282