azcontainerregistry: move method to function #23270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @stevekuznetsov! We will review the pull request and get back to you soon. |
chlowell
approved these changes
Aug 2, 2024
The Go documentation strongly discourages structs from having methods with both pointer recievers and non-pointer recievers. For the auth policy, `getChallengeRequest` presumably did not have a pointer reciever since it did not make use of the struct at all. We can simply move this to a function. Signed-off-by: Steve Kuznetsov <[email protected]>
auto-merge was automatically disabled
August 5, 2024 14:11
Head branch was pushed to by a user without write access
stevekuznetsov
force-pushed
the
skuznets/method-to-function
branch
from
1b414de to
f644995
Compare
|
@tadelesh sorry, looks like auto-merge didn't go through. Updated the formatting, pushed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go documentation strongly discourages structs from having methods with both pointer recievers and non-pointer recievers. For the auth policy,
getChallengeRequestpresumably did not have a pointer reciever since it did not make use of the struct at all. We can simply move this to a function.