Refactor handling of sync tokens #21589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added internal package synctoken that contains the sync token cache and pipeline policy implementations. Renamed UpdateSyncToken to setSyncToken so it follows the design guidelines. In addition, it returns an error on malformed sync tokens. Removed setting sync token from test as it's not necessary (the policy already does this).
github-actions
bot
added
the
App Configuration
jhendrixMSFT
commented
Sep 19, 2023
|
/azp run go - azappconfig |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chlowell
approved these changes
Sep 20, 2023
|
/azp run go - azappconfig |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added internal package synctoken that contains the sync token cache and pipeline policy implementations.
Renamed UpdateSyncToken to SetSyncToken so it follows the design guidelines. In addition, it returns an error on malformed sync tokens. Removed setting sync token from test as it's not necessary (the policy already does this).
Fixes #21585