Return specific errors when parsing connection strings #21586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include failure details instead of a generic error message. Some other minor cleanup.
github-actions
bot
added
the
App Configuration
RickWinter
approved these changes
Sep 19, 2023
richardpark-msft
approved these changes
Sep 19, 2023
| ) | ||
|
|
||
| const duplicateSection = "duplicate %s section" | ||
|
|
||
| for _, seg := range strings.Split(connectionString, ";") { |
There was a problem hiding this comment.
Nothing wrong with the fix but are people actually running into this? I was under the impression that most people don't form connection strings by hand - bug in the portal?
There was a problem hiding this comment.
I doubt it. The generic error message reminded me of COM's E_FAIL which isn't all that helpful. Furthermore, we already know at each point of failure what the problem is, so seems useful to return that info.
| var cred *string | ||
| var sec *[]byte | ||
| // Returns endpoint, cred, secret or an error. | ||
| func ParseConnectionString(connectionString string) (string, string, []byte, error) { |
There was a problem hiding this comment.
At some point you've got to be considering returning this as a struct...
There was a problem hiding this comment.
I thought about it, but it seems like extra ceremony for something that's internal and unlikely to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include failure details instead of a generic error message. Some other minor cleanup.