Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recreate body after reading #21580

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Don't recreate body after reading #21580

merged 2 commits into from
Sep 19, 2023

Conversation

jhendrixMSFT
Copy link
Member

Rewind the body instead. And if it was nil, leave it as nil. Removed some unnecessary local vars.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT
Don't recreate body after reading
8f39dbd 
Rewind the body instead. And if it was nil, leave it as nil.
Removed some unnecessary local vars.
@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Sep 18, 2023
chlowell
chlowell approved these changes Sep 19, 2023
View reviewed changes
sdk/data/azappconfig/assets.json Show resolved Hide resolved
@jhendrixMSFT jhendrixMSFT merged commit b356b4a into Azure:main Sep 19, 2023
10 checks passed
@jhendrixMSFT jhendrixMSFT deleted the azappconfig-cleanup branch September 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@antkmsft antkmsft Awaiting requested review from antkmsft

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @chlowell