Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert client test to use recordings #21540

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

jhendrixMSFT
Copy link
Member

A little clean-up of the test code.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

A little clean-up of the test code.
@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Sep 12, 2023
@jhendrixMSFT
Copy link
Member Author

jhendrixMSFT commented Sep 12, 2023

Regarding #17789 which was mostly fixed (live tests were already working).

@jhendrixMSFT jhendrixMSFT merged commit 7117f02 into Azure:main Sep 12, 2023
@jhendrixMSFT jhendrixMSFT deleted the azappconfig-recordings branch September 12, 2023 22:04
chlowell pushed a commit to chlowell/azure-sdk-for-go that referenced this pull request Sep 20, 2023
* Convert client test to use recordings

A little clean-up of the test code.

* don't defer in the same func as os.Exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants