armstorageimportexport - clean up client constructors

[jhendrixMSFT]

We don't allow optional client constructor parameters for ARM. Use an autorest transform until the OpenAPI has been fixed.

• The purpose of this PR is explained in this or a referenced issue.
• The PR does not update generated files.
  • These files are managed by the codegen framework at Azure/autorest.go.
• Tests are included and/or updated for code changes.
• Updates to module CHANGELOG.md are included.
• MIT license headers are included in each file.

[tadelesh]

@jhendrixMSFT do you mean it is illegal to have optional client param for arm? There is another service with required client param:

azure-sdk-for-go/sdk/resourcemanager/apicenter/armapicenter/services_client.go

Line 36 in 8166b03

func NewServicesClient(subscriptionID string, serviceName string, credential azcore.TokenCredential, options *arm.ClientOptions) (*ServicesClient, error) {

, it is legal?

[jhendrixMSFT]

The *arm.ClientOptions type is legal and expected. In your example, serviceName looks to be required?

Recent versions of the code generator will reject specs for ARM that contain optional client parameters.

[jhendrixMSFT]

I wonder though, should serviceName actually be a client parameter? It's almost always the wrong choice.

[tadelesh]

I wonder though, should serviceName actually be a client parameter? It's almost always the wrong choice.

I'm also has such concern. Go just followed other languages. I'll try to confirm with service team.