Use subscription configuration variables for openai live tests #21287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benbp
commented
Jul 28, 2023
benbp
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
benbp
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
benbp
added
the
Central-EngSys
benbp
force-pushed
the
benbp/openai-sub-config
branch
from
3afcbfd to
5232dd5
Compare
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azopenai |
|
(one key was out of date, but there's some other failures relating to identity) |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/openai-sub-config
branch
from
5232dd5 to
47f5abc
Compare
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@richardpark-msft did you want to approve? |
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Let's get it to pass. I added in some variables I added in the other pipeline as well. |
|
@richardpark-msft ah sorry, when I commented all the tests were green so I thought you had. |
benbp
force-pushed
the
benbp/openai-sub-config
branch
2 times, most recently
from
a87aea4 to
5ac23e4
Compare
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/openai-sub-config
branch
from
5ac23e4 to
6ad85f2
Compare
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/openai-sub-config
branch
from
6ad85f2 to
d758c2b
Compare
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azopenai |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
approved these changes
Oct 3, 2023
benbp
force-pushed
the
benbp/openai-sub-config
branch
from
f59bd6a to
d758c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.