Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress nested SDK method spans #21251

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

jhendrixMSFT
Copy link
Member

The inner SDK span must be omitted. However, any REST span it creates must be a child of the outer SDK method span.

https://azure.github.io/azure-sdk/general_implementation.html#distributed-tracing

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for current scenarios just left a comment that should be addressed to make messaging instrumentation work

The inner SDK span must be omitted.  However, any REST span it creates
must be a child of the outer SDK method span.
@jhendrixMSFT jhendrixMSFT merged commit 7aa0180 into Azure:main Aug 18, 2023
@jhendrixMSFT jhendrixMSFT deleted the azcore_nested_spans branch August 18, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants