Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing telemetry #21175

Closed
wants to merge 7 commits into from
Closed

Fixing telemetry #21175

wants to merge 7 commits into from

Conversation

siminsavani-msft
Copy link
Contributor

@siminsavani-msft siminsavani-msft commented Jul 14, 2023 •
edited
Loading

Fixes #21023

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@siminsavani-msft
Regenerating AzBlob to STG 85/86 (Azure#20724)
e0a1e31 
* Regenerating azblob to stg 85/86

* Updating CopyFromURL

* minor change

* minor fixes

* undo some minor fixes

* Updating Go code generator

* Fixing calls to pipeline

* Adding custom UnmarshalXML for BlobItem and BlobPrefix

* Updating constructor method for AppendBlobClient

* Updating Client constructors

* Undoing minor fixes to blob examples

* Fixing authpolicy

* Updating azcore version

* Fixing client strings

* Const for service client

* Minor fix

* fixing go mod files

* Shared constants client name

* Addressing comments
@siminsavani-msft
[Feature STG 85/86] Cold Tier (Azure#21032)
f0e677c 
* Adding Cold Tier + tests

* Recorded tests

* Updated CHANGELOG.md

* Fixing linting issues

* Updating Cold tier test and recording

* Addressing commits
@siminsavani-msft
[Checksum Work] BlockBlob Client: Transactional/Source Content Valida…
f2f2922 
…tion (Azure#21033)

* Adding test for transactional validation in block blob

* StageBlockFromURL tests

* Deprecating options in CommitBlockList

* CopyFromURL test

* Updating checksum behavior

* Record tests

* Updated recording

* Updated recording again

* Added error for user gen checksums, tests for UploadStream, UploadBuffer, and UploadFile

* Added recorded test

* Updated CommitBlockList, added tests for CommitBlockList, and added CRC64 test for Upload

* Updating UploadStream test

* Recorded test

* Recorded test

* Fixing CommitBlockList errors

* Fixing linting issues

* Addressing comment + handling CI issues

* Removing TransactionalValidation from CommitBlockList + cleaning up tests

* Rerecorded tests
@siminsavani-msft
Updating azcore
db9e4ba
@siminsavani-msft
Updating changelog.md
cede507
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 14, 2023
@jhendrixMSFT
Copy link
Member

The dependency check failure is tracked by #21116 and can be ignored.

@jhendrixMSFT
Copy link
Member

After closer inspection, I think the issue is that the target branch is a bit behind what's in main. While it's still safe to ignore the error, it might be worth updating the branch if there is more pending work.

@jhendrixMSFT jhendrixMSFT force-pushed the feature/azblob-stg85/86 branch from f2f2922 to cc5f011 Compare July 17, 2023 19:15
@siminsavani-msft
Copy link
Contributor Author

New PR here: #21188

@siminsavani-msft siminsavani-msft deleted the fixing-telemetry branch July 17, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siminsavani-msft @jhendrixMSFT