Add doc links to fakes example #21008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhendrixMSFT
commented
Jun 12, 2023
jhendrixMSFT
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
jhendrixMSFT
requested review from
ArcturusZhang,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
tadelesh
approved these changes
Jun 13, 2023
|
It seems relative links is not allowed. |
|
@benbp it seems that using a |
|
@jhendrixMSFT IIRC we may have either an exception and/or cache process for relative links. I need to dig. |
|
Hi @jhendrixMSFT. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
jhendrixMSFT
force-pushed
the
fake_docs
branch
from
1256452 to
fa8e01b
Compare
|
Switched to absolute links. It would be great if relative links work in the future. |
github-actions
bot
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.