Refinement of fake package per API review #20866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an HTTP status code parameter to to methods that return a response. For methods that already had such a paraemter, it was relocated to be the first parameter. Removed Responder[T].SetHeader method, replacing the functionality with an http.Header field in SetResponseOptions. Cleaned up some wording in the server API doc comments.
jhendrixMSFT
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
the fake package contains the user-facing APIs. the server package contains APIs used by generated code. added a shared NonRetriableError helper.
|
|
jhendrixMSFT
commented
May 18, 2023
jhendrixMSFT
commented
May 18, 2023
JeffreyRichter
approved these changes
May 24, 2023
jhendrixMSFT
added a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an HTTP status code parameter to to methods that return a response. For methods that already had such a paraemter, it was relocated to be the first parameter.
Removed Responder[T].SetHeader method, replacing the functionality with an http.Header field in SetResponseOptions.
Cleaned up some wording in the server API doc comments.