Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container soft delete #19136

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Container soft delete #19136

merged 4 commits into from
Sep 22, 2022

Conversation

souravgupta-msft
Copy link
Member

@souravgupta-msft souravgupta-msft commented Sep 16, 2022 •
edited
Loading

Added code for restoring soft-deleted container

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Sep 16, 2022
siminsavani-msft
siminsavani-msft approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@siminsavani-msft siminsavani-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nakulkar-msft
nakulkar-msft suggested changes Sep 21, 2022
View reviewed changes
sdk/storage/azblob/container/client.go Outdated Show resolved Hide resolved
sdk/storage/azblob/service/client.go Outdated Show resolved Hide resolved
@souravgupta-msft souravgupta-msft merged commit 81279eb into main Sep 22, 2022
@souravgupta-msft souravgupta-msft deleted the sourav/restoreContainer branch September 22, 2022 09:38
@siminsavani-msft siminsavani-msft added this to the azblob v0.5.2 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@siminsavani-msft siminsavani-msft siminsavani-msft approved these changes

@tasherif-msft tasherif-msft tasherif-msft approved these changes

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@nakulkar-msft nakulkar-msft nakulkar-msft approved these changes

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azblob v1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@souravgupta-msft @jhendrixMSFT @nakulkar-msft @vibhansa-msft @tasherif-msft @siminsavani-msft