Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Query #18981

Merged
merged 30 commits into from
Sep 8, 2022
Merged

Monitor Query #18981

merged 30 commits into from
Sep 8, 2022

Conversation

gracewilcox
Copy link
Member

@gracewilcox gracewilcox commented Aug 30, 2022

Fixes #18776

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

@gracewilcox
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gracewilcox
Copy link
Member Author

/azp run go - azquery

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gracewilcox gracewilcox marked this pull request as ready for review September 8, 2022 20:50
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything too bad or objectionable.

For the next beta I think we should concentrate on getting those examples so they demonstrate some bits of Kusto, and display/print out some of the results. Any time there's an any/interface{} type you need to show how to pick it apart.

Take a look at the comments, fix any you think you can do reasonably and just file issues for the rest for beta.2.

eng/config.json Show resolved Hide resolved
sdk/monitor/azquery/README.md Show resolved Hide resolved
sdk/monitor/azquery/README.md Outdated Show resolved Hide resolved
sdk/monitor/azquery/README.md Outdated Show resolved Hide resolved
sdk/monitor/azquery/README.md Show resolved Hide resolved
sdk/monitor/azquery/README.md Outdated Show resolved Hide resolved
sdk/monitor/azquery/README.md Show resolved Hide resolved
sdk/monitor/azquery/custom_client.go Outdated Show resolved Hide resolved
sdk/monitor/azquery/metrics_client.go Show resolved Hide resolved
@gracewilcox gracewilcox merged commit 505d524 into Azure:main Sep 8, 2022
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Monitor Query for GO
3 participants