Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split buffer and file download options into their own types #18896

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Split buffer and file download options into their own types #18896

merged 2 commits into from
Aug 18, 2022

Conversation

jhendrixMSFT
Copy link
Member

@jhendrixMSFT jhendrixMSFT commented Aug 18, 2022 •
edited
Loading

This allows the options for each API to independently evolve over time.
Fixed potential panic in some helper methods.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Aug 18, 2022
@jhendrixMSFT
Split buffer and file download options into their own types
7ce04ba 
This allows the options for each API to independently evolve over time.
Fixed potential panic in some helper methods.
JeffreyRichter
JeffreyRichter approved these changes Aug 18, 2022
View reviewed changes
sdk/storage/azblob/blob/models.go Outdated Show resolved Hide resolved
@jhendrixMSFT jhendrixMSFT merged commit 03952f8 into Azure:main Aug 18, 2022
@jhendrixMSFT jhendrixMSFT deleted the azblob_dl_options branch August 18, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@mohsha-msft mohsha-msft Awaiting requested review from mohsha-msft

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @JeffreyRichter