-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting and linting errors following 1.19 upgrade #18808
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For track 2 SDKs Issue the following command as a pull request comment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best comments I've ever seen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing two single quotes with double quotes in the new gofmt
will lead to some incorrect comments. Maybe we need to refine the swagger description to avoid using two single quotes.
sdk/resourcemanager/resources/armpolicy/zz_generated_assignments_client.go
Show resolved
Hide resolved
Hey @chlowell, I had to gofmt azservicebus so there'll be some conflicts. Probably easiest to just merge with main. |
cherry-picked #18822 because some modules in this PR need that fix as well 🙄 |
The new
gofmt
adds rules for doc comments. These will create diffs, and thus failures, in CI after upgrading pipelines to 1.19, so for this PR I ran the updatedgofmt
onsdk/**/*
. We also have new linter warnings because the upgraded golangci-lint warns on io/ioutil usage.