Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and linting errors following 1.19 upgrade #18808

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Aug 8, 2022

The new gofmt adds rules for doc comments. These will create diffs, and thus failures, in CI after upgrading pipelines to 1.19, so for this PR I ran the updated gofmt on sdk/**/*. We also have new linter warnings because the upgraded golangci-lint warns on io/ioutil usage.

@check-enforcer
Copy link

check-enforcer bot commented Aug 8, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best comments I've ever seen.

Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing two single quotes with double quotes in the new gofmt will lead to some incorrect comments. Maybe we need to refine the swagger description to avoid using two single quotes.

@chlowell chlowell mentioned this pull request Aug 9, 2022
@richardpark-msft
Copy link
Member

Hey @chlowell, I had to gofmt azservicebus so there'll be some conflicts. Probably easiest to just merge with main.

@chlowell chlowell requested a review from antkmsft as a code owner August 9, 2022 20:03
@chlowell
Copy link
Member Author

chlowell commented Aug 9, 2022

cherry-picked #18822 because some modules in this PR need that fix as well 🙄

@chlowell chlowell changed the title fmt with Go 1.19 Fix formatting and linting errors following 1.19 upgrade Aug 9, 2022
@chlowell chlowell merged commit 2917528 into Azure:main Aug 9, 2022
@chlowell chlowell deleted the fmt branch August 9, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants