-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos DB: Add AAD authentication #17742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
reviewed
Apr 26, 2022
milismsft
approved these changes
Apr 26, 2022
haitch
reviewed
Apr 26, 2022
jhendrixMSFT
approved these changes
Apr 27, 2022
chlowell
approved these changes
Apr 27, 2022
Co-authored-by: Charles Lowell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
azcore.TokenCredential
as authentication method to the Cosmos DB SDK.How to create a client with AAD
Using the default credential:
Using a client secret:
API changes
There is only a single API change, which adds the new client constructor:
APIView https://apiview.dev/Assemblies/Review/ca456a2f7ed64556b3fb57ecebc0b9d2/cc654e57f8044ed8a14c5dbf421ab49b?diffRevisionId=54a33d355ba146cb8e595448aa039540&doc=False&diffOnly=True
(There are other bogus differences due to reordering of existing properties)
Closes #16219